Visitar URL original
GH-98363: Add itertools.batched() by rhettinger · Pull Request #98364 · python/cpython · GitHub
Skip to content

GH-98363: Add itertools.batched() - #98364

Merged
rhettinger merged 24 commits into
python:mainfrom
rhettinger:itertools_batched
Oct 17, 2022
Merged

GH-98363: Add itertools.batched()#98364
rhettinger merged 24 commits into
python:mainfrom
rhettinger:itertools_batched

Conversation

@rhettinger

@rhettinger rhettinger commented Oct 17, 2022 •
edited by bedevere-bot
Loading

Copy link
Copy Markdown
Contributor

@rhettinger rhettinger added type-feature A feature request or enhancement 3.12 only security fixes labels Oct 17, 2022
JelleZijlstra
JelleZijlstra reviewed Oct 17, 2022
View reviewed changes

@JelleZijlstra JelleZijlstra left a comment

Copy link
Copy Markdown
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I agree with adding this, just a few small comments.

Comment thread Lib/test/test_itertools.py Outdated
Comment thread Modules/itertoolsmodule.c
Comment thread Modules/itertoolsmodule.c
@rhettinger rhettinger added the 🔨 test-with-buildbots Test PR w/ buildbots; report in status section label Oct 17, 2022
@bedevere-bot

bedevere-bot commented Oct 17, 2022

Copy link
Copy Markdown

🤖 New build scheduled with the buildbot fleet by @rhettinger for commit b9cbb46 🤖

If you want to schedule another build, you need to add the ":hammer: test-with-buildbots" label again.

@bedevere-bot bedevere-bot removed the 🔨 test-with-buildbots Test PR w/ buildbots; report in status section label Oct 17, 2022
TeamSpen210
TeamSpen210 reviewed Oct 17, 2022
View reviewed changes
Comment thread Doc/library/itertools.rst Outdated
sweeneyde
sweeneyde reviewed Oct 17, 2022
View reviewed changes
Comment thread Modules/itertoolsmodule.c
@rhettinger
rhettinger merged commit de3ece7 into python:main Oct 17, 2022
gvanrossum
gvanrossum reviewed Oct 23, 2022
View reviewed changes
Comment thread Doc/library/itertools.rst
Roughly equivalent to::

def batched(iterable, n):
# batched('ABCDEFG', 3) --> ABC DEF G

@gvanrossum gvanrossum Oct 23, 2022

Copy link
Copy Markdown
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Maybe tweak the example so it cannot be misunderstood as "return 3 batches"?

@anderssonjohan anderssonjohan Oct 25, 2022

Copy link
Copy Markdown

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Suggested change
# batched('ABCDEFG', 3) --> ABC DEF G
# list(batched('ABCDEFG', 3)) --> [['A', 'B', 'C'], ['D', 'E', 'F'], ['G']]

@lgeiger lgeiger mentioned this pull request Nov 1, 2024
Closed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

@JelleZijlstra JelleZijlstra JelleZijlstra left review comments
@gvanrossum gvanrossum gvanrossum left review comments
@sweeneyde sweeneyde sweeneyde left review comments
+2 more reviewers
@anderssonjohan anderssonjohan anderssonjohan left review comments
@TeamSpen210 TeamSpen210 TeamSpen210 left review comments
Reviewers whose approvals may not affect merge requirements

Assignees

No one assigned

Labels

3.12 only security fixes type-feature A feature request or enhancement

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

7 participants

@rhettinger @bedevere-bot @anderssonjohan @JelleZijlstra @gvanrossum @TeamSpen210 @sweeneyde