Visitar URL original
gh-85267: Improvements to inspect.signature __text_signature__ handling by hauntsaninja · Pull Request #98796 · python/cpython · GitHub
Skip to content

gh-85267: Improvements to inspect.signature __text_signature__ handling #98796

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
JelleZijlstra merged 7 commits into from
Dec 21, 2022
Merged

gh-85267: Improvements to inspect.signature __text_signature__ handling #98796

Changes from 1 commit
Commits
Show all changes
7 commits
Select commit Hold shift + click to select a range
16ae02e
gh-85267: Improvements to inspect.signature __text_signature__ handling
hauntsaninja Oct 28, 2022
b60fb02
📜🤖 Added by blurb_it.
blurb-it[bot] Oct 28, 2022
dd2e08f
Update Lib/test/test_inspect.py
hauntsaninja Nov 9, 2022
ea41f40
Update Lib/test/test_inspect.py
hauntsaninja Nov 9, 2022
7f9f257
another runtime error
hauntsaninja Nov 9, 2022
126b8c3
add a comment
hauntsaninja Nov 9, 2022
fef9787
Merge branch 'main' into inspect-signature
JelleZijlstra Dec 12, 2022
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
Prev Previous commit
Next Next commit
add a comment
  • Loading branch information
@hauntsaninja
hauntsaninja committed Nov 9, 2022
commit 126b8c3fc674346b0ee6d773ec30a28579505aaf
2 changes: 2 additions & 0 deletions Lib/inspect.py
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -2233,6 +2233,8 @@ def visit_Name(self, node):
return wrap_value(node.id)

def visit_BinOp(self, node):
Comment thread
hauntsaninja marked this conversation as resolved.
# Support constant folding of a couple simple binary operations
# commonly used to define default values in text signatures
left = self.visit(node.left)
right = self.visit(node.right)
if not isinstance(left, ast.Constant) or not isinstance(right, ast.Constant):
Expand Down