Visitar URL original
PEP 8104: 2023 Term Steering Council election by ewdurbin · Pull Request #2875 · python/peps · GitHub
Skip to content

PEP 8104: 2023 Term Steering Council election - #2875

Merged
ewdurbin merged 6 commits into
mainfrom
2023_term_sc_election
Nov 14, 2022
Merged

PEP 8104: 2023 Term Steering Council election#2875
ewdurbin merged 6 commits into
mainfrom
2023_term_sc_election

Conversation

@ewdurbin

@ewdurbin ewdurbin commented Nov 8, 2022

Copy link
Copy Markdown
Member

Initial draft with pertinent dates and details.

@ewdurbin
ewdurbin requested a review from brettcannon November 8, 2022 20:31
@ewdurbin
ewdurbin requested a review from a team as a code owner November 8, 2022 20:31
JelleZijlstra
JelleZijlstra reviewed Nov 8, 2022
View reviewed changes
Comment thread pep-8104.rst Outdated
@ewdurbin @JelleZijlstra
Update pep-8104.rst
7057c93 
Co-authored-by: Jelle Zijlstra <jelle.zijlstra@gmail.com>
@CAM-Gerlach CAM-Gerlach changed the title PEP 8104 - 2023 Term Steering Council election PEP 8104: 2023 term Steering Council election Nov 8, 2022
@CAM-Gerlach CAM-Gerlach added the new-pep A new draft PEP submitted for initial review label Nov 8, 2022
AA-Turner
AA-Turner reviewed Nov 8, 2022
View reviewed changes

@AA-Turner AA-Turner left a comment

Copy link
Copy Markdown
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Elided two blocks that are no longer needed:

A

Comment thread pep-8104.rst Outdated
Comment thread pep-8104.rst Outdated
ewdurbin and others added 2 commits November 8, 2022 17:27
@ewdurbin @AA-Turner
Update pep-8104.rst
7048570 
Co-authored-by: Adam Turner <9087854+AA-Turner@users.noreply.github.com>
@ewdurbin @AA-Turner
Update pep-8104.rst
a71642f 
Co-authored-by: Adam Turner <9087854+AA-Turner@users.noreply.github.com>
CAM-Gerlach
CAM-Gerlach reviewed Nov 8, 2022
View reviewed changes
Comment thread pep-8104.rst Outdated
Comment thread pep-8104.rst Outdated
Comment thread pep-8104.rst Outdated
Comment thread pep-8104.rst Outdated
Comment thread pep-8104.rst Outdated
Comment thread pep-8104.rst Outdated
Comment thread pep-8104.rst Outdated
Comment thread pep-8104.rst Outdated
Comment thread pep-8104.rst Outdated
Comment thread pep-8104.rst Outdated
@CAM-Gerlach CAM-Gerlach changed the title PEP 8104: 2023 term Steering Council election PEP 8104: 2023 Term Steering Council election Nov 8, 2022
@ewdurbin @CAM-Gerlach
Apply suggestions from code review
ffbf766 
Co-authored-by: C.A.M. Gerlach <CAM.Gerlach@Gerlach.CAM>
CAM-Gerlach
CAM-Gerlach approved these changes Nov 8, 2022
View reviewed changes

@CAM-Gerlach CAM-Gerlach left a comment •
edited
Loading

Copy link
Copy Markdown
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM, thanks @ewdurbin

Unrelated, but as I was reminded by how easy it was to just check the preview as opposed to a manual local build, and we've all been eagerly looking forward to it...can we get the docs previews enabled now? :)

@JelleZijlstra

JelleZijlstra commented Nov 8, 2022

Copy link
Copy Markdown
Member

Do you mean something else than https://pep-previews--2875.org.readthedocs.build/pep-8104/ ?

@CAM-Gerlach

CAM-Gerlach commented Nov 8, 2022

Copy link
Copy Markdown
Member

hugovk
hugovk reviewed Nov 8, 2022
View reviewed changes
Comment thread pep-8104.rst Outdated
Comment thread pep-8104.rst Outdated
Comment thread pep-8104.rst Outdated
brettcannon
brettcannon requested changes Nov 9, 2022
View reviewed changes

@brettcannon brettcannon left a comment

Copy link
Copy Markdown
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I think we should get the times consistent by only specifying AoE or UTC (my vote is AoE).

Comment thread pep-8104.rst Outdated
Comment thread pep-8104.rst Outdated
@ewdurbin
ewdurbin requested a review from brettcannon November 14, 2022 13:30
@ewdurbin
ewdurbin merged commit c1d17d8 into main Nov 14, 2022
@ewdurbin
ewdurbin deleted the 2023_term_sc_election branch November 14, 2022 13:36
CAM-Gerlach
CAM-Gerlach reviewed Nov 14, 2022
View reviewed changes
Comment thread pep-8104.rst
@ewdurbin ewdurbin mentioned this pull request Dec 6, 2022
Closed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

@JelleZijlstra JelleZijlstra JelleZijlstra left review comments
@hugovk hugovk hugovk left review comments
@AA-Turner AA-Turner AA-Turner left review comments
@CAM-Gerlach CAM-Gerlach CAM-Gerlach approved these changes
@brettcannon brettcannon Awaiting requested review from brettcannon

Assignees

No one assigned

Labels

new-pep A new draft PEP submitted for initial review

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

6 participants

@ewdurbin @JelleZijlstra @CAM-Gerlach @brettcannon @hugovk @AA-Turner