Visitar URL original
Dark theme · Issue #43 · python/python-docs-theme · GitHub
Skip to content

Dark theme #43

Description

@vitaly-zdanevich

Please save our eyes. And batteries. Do not ignore this property of useragent https://developer.mozilla.org/en-US/docs/Web/CSS/@media/prefers-color-scheme

Cross-defect with https://bugs.python.org/issue39518

Activity

  1. opensource-assist commented on Feb 3, 2020

    @opensource-assist
  2. vitaly-zdanevich commented on Feb 4, 2020

    @vitaly-zdanevich
    Author

    I know about such extensions, but this is only for desktop browser. Youtube has dark theme, Google Calendar has dark theme on mobile - this is basic feature, dark theme is not for beauty - dark theme is against pain in eyes.

    You need to add maybe 10 lines of CSS. I can do it if you approve me.

  3. opensource-assist commented on Feb 4, 2020

    @opensource-assist

    @vitaly-zdanevich

    I know about such extensions, but this is only for desktop browser. Youtube has dark theme, Google Calendar has dark theme on mobile - this is basic feature, dark theme is not for beauty - dark theme is against pain in eyes.

    You need to add maybe 10 lines of CSS. I can do it if you approve me.

    Why don't you do the PR on CPython's repo? The docs are served in there.

  4. vitaly-zdanevich commented on Feb 4, 2020

    @vitaly-zdanevich
    Author

    But theme is in this repository.

  5. septatrix commented on Feb 5, 2020

    @septatrix
    Contributor

    If you don't mind I'd like to work on this issue and make a pull request with some design drafts...

  6. vitaly-zdanevich commented on Feb 5, 2020

    @vitaly-zdanevich
    Author

    Ok.

  7. septatrix commented on Feb 5, 2020

    @septatrix
    Contributor

    Just pushed a first draft if you want to take a look (#44)...

  8. flying-sheep commented on Oct 25, 2022

    @flying-sheep

    What’s missing before #44 will be merged?

  9. hugovk commented on Oct 25, 2022

    @hugovk
    Member

    We're currently blocked due to lack of clarity whether we can use Sphinx 3 or need to keep support for 1.8:

    #44 (comment)

  10. AA-Turner commented on Oct 25, 2022

    @AA-Turner
    Member

    It was resolved to 3.2 (python/cpython#93337), though the pin to python-docs-theme==2022.1 should probably be introduced and backported to all non EOL versions, which are currently all unpinned (https://github.com/python/cpython/blob/3.7/Doc/requirements.txt#L18)

    A

  11. septatrix commented on Nov 4, 2022

    @septatrix
    Contributor

    I should have time to rebase the PR on the current master this weekend

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Metadata

Metadata

Assignees

No one assigned

    Labels

    No labels
    No labels

    Projects

    No projects

      Milestone

      No milestone

      Relationships

      None yet

      Development

      No branches or pull requests

      Issue actions