Visitar URL original
Fix translation of html pages by StanFromIreland · Pull Request #263 · python/python-docs-theme · GitHub
Skip to content

Fix translation of html pages - #263

Merged
hugovk merged 3 commits into
python:mainfrom
StanFromIreland:fix-translation
Sep 15, 2025
Merged

Fix translation of html pages#263
hugovk merged 3 commits into
python:mainfrom
StanFromIreland:fix-translation

Conversation

@StanFromIreland

@StanFromIreland StanFromIreland commented Sep 9, 2025 •
edited by github-actions Bot
Loading

Copy link
Copy Markdown
Member

There two issues, firstly some languages were not compiled and therefore don't load (e.g. Polish), and secondly, we hijacked the gettext for html files with python-docs-theme.po, resulting in messages in sphinx.po not loading (e.g. Greek).

Complete preview, built with translations: https://stan.ulbrych.org/preview/theme-translation/ (vs. current docs)

Compilation issue

We now get:

compiling catalog python_docs_theme/locale/zh_TW/LC_MESSAGES/python-docs-theme.po to python_docs_theme/locale/zh_TW/LC_MESSAGES/python-docs-theme.mo
compiling catalog python_docs_theme/locale/tr/LC_MESSAGES/python-docs-theme.po to python_docs_theme/locale/tr/LC_MESSAGES/python-docs-theme.mo
compiling catalog python_docs_theme/locale/pt_BR/LC_MESSAGES/python-docs-theme.po to python_docs_theme/locale/pt_BR/LC_MESSAGES/python-docs-theme.mo
compiling catalog python_docs_theme/locale/sv/LC_MESSAGES/python-docs-theme.po to python_docs_theme/locale/sv/LC_MESSAGES/python-docs-theme.mo
compiling catalog python_docs_theme/locale/pl/LC_MESSAGES/python-docs-theme.po to python_docs_theme/locale/pl/LC_MESSAGES/python-docs-theme.mo
compiling catalog python_docs_theme/locale/ja/LC_MESSAGES/python-docs-theme.po to python_docs_theme/locale/ja/LC_MESSAGES/python-docs-theme.mo
compiling catalog python_docs_theme/locale/zh_CN/LC_MESSAGES/python-docs-theme.po to python_docs_theme/locale/zh_CN/LC_MESSAGES/python-docs-theme.mo
compiling catalog python_docs_theme/locale/es/LC_MESSAGES/python-docs-theme.po to python_docs_theme/locale/es/LC_MESSAGES/python-docs-theme.mo
compiling catalog python_docs_theme/locale/el/LC_MESSAGES/python-docs-theme.po to python_docs_theme/locale/el/LC_MESSAGES/python-docs-theme.mo

📚 Documentation preview 📚: https://python-docs-theme-previews--263.org.readthedocs.build/

@StanFromIreland StanFromIreland mentioned this pull request Sep 9, 2025
Merged
4 tasks done
StanFromIreland
StanFromIreland commented Sep 9, 2025
View reviewed changes
Comment thread python_docs_theme/__init__.py
rffontenelle
rffontenelle approved these changes Sep 9, 2025
View reviewed changes

@rffontenelle rffontenelle left a comment

Copy link
Copy Markdown
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

m-aciek
m-aciek reviewed Sep 9, 2025
View reviewed changes
Comment thread python_docs_theme/__init__.py Outdated
hugovk
hugovk reviewed Sep 10, 2025
View reviewed changes
Comment thread python_docs_theme/__init__.py Outdated
Comment thread python_docs_theme/__init__.py Outdated
Comment thread python_docs_theme/__init__.py Outdated
@StanFromIreland

StanFromIreland commented Sep 10, 2025

Copy link
Copy Markdown
Member Author

Added type hints per documentation.

@hugovk
hugovk merged commit fee2ae0 into python:main Sep 15, 2025
12 checks passed
@StanFromIreland
StanFromIreland deleted the fix-translation branch September 15, 2025 16:41
@StanFromIreland StanFromIreland mentioned this pull request Apr 4, 2026
Open
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

@hugovk hugovk hugovk approved these changes
+2 more reviewers
@m-aciek m-aciek m-aciek left review comments
@rffontenelle rffontenelle rffontenelle approved these changes
Reviewers whose approvals may not affect merge requirements

Assignees

No one assigned

Labels

None yet

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

4 participants

@StanFromIreland @hugovk @rffontenelle @m-aciek