Visitar URL original
Keep breadcrumbs visible on mobile by undeMalum · Pull Request #326 · python/python-docs-theme · GitHub
Skip to content

Keep breadcrumbs visible on mobile - #326

Merged
hugovk merged 4 commits into
python:mainfrom
undeMalum:keep-mobile-breadcrumbs
Sep 10, 2026
Merged

Keep breadcrumbs visible on mobile#326
hugovk merged 4 commits into
python:mainfrom
undeMalum:keep-mobile-breadcrumbs

Conversation

@undeMalum

@undeMalum undeMalum commented Aug 30, 2026

Copy link
Copy Markdown
Contributor

Closes #317

Before the change:
image

After the change:
image

@python-cla-bot

python-cla-bot Bot commented Aug 30, 2026 •
edited
Loading

Copy link
Copy Markdown

All commit authors signed the Contributor License Agreement.

CLA signed

@read-the-docs-community

read-the-docs-community Bot commented Aug 30, 2026 •
edited
Loading

Copy link
Copy Markdown

Documentation build overview

📚 python-docs-theme-previews | 🛠️ Build #34301357 | 📁 Comparing 5b3e4d3 against latest (466e123)

  🔍 Preview build  

59 files changed · + 1 added · ± 58 modified

+ Added

± Modified

@hugovk

hugovk commented Aug 30, 2026

Copy link
Copy Markdown
Member

Thanks for the PR. Should we remove the Python logo in mobile? And possibly reduce the vertical gap between the breadcrumb lines a bit?

@undeMalum

undeMalum commented Aug 30, 2026

Copy link
Copy Markdown
Contributor Author

Thanks for the PR. Should we remove the Python logo in mobile? And possibly reduce the vertical gap between the breadcrumb lines a bit?

Now it looks like this:
image

m-aciek
m-aciek suggested changes Aug 30, 2026
View reviewed changes

@m-aciek m-aciek left a comment

Copy link
Copy Markdown
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thank you for the changes! Leaving two suggestions.

Comment thread python_docs_theme/static/pydoctheme.css Outdated
Comment thread python_docs_theme/static/pydoctheme.css Outdated
undeMalum and others added 2 commits August 30, 2026 20:31
@undeMalum @m-aciek
Update python_docs_theme/static/pydoctheme.css
84a3e45 
Co-authored-by: Maciej Olko <maciej.olko@gmail.com>
@undeMalum @m-aciek
Update python_docs_theme/static/pydoctheme.css
5b3e4d3 
Co-authored-by: Maciej Olko <maciej.olko@gmail.com>
@hugovk

hugovk commented Aug 30, 2026 •
edited
Loading

Copy link
Copy Markdown
Member

@undeMalum Please can you sign the CLA with your other email as well?

#326 (comment)

See https://devguide.python.org/getting-started/pull-request-lifecycle/#why-do-i-need-to-sign-the-cla-again

@m-aciek

m-aciek commented Sep 9, 2026

Copy link
Copy Markdown
Contributor

@hugovk @undeMalum has signed the CLA with his second email.

hugovk
hugovk approved these changes Sep 10, 2026
View reviewed changes

@hugovk hugovk left a comment

Copy link
Copy Markdown
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks!

@hugovk
hugovk merged commit d3002a5 into python:main Sep 10, 2026
14 checks passed
@m-aciek m-aciek mentioned this pull request Sep 10, 2026
Open
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

@hugovk hugovk hugovk approved these changes
+1 more reviewer
@m-aciek m-aciek m-aciek approved these changes
Reviewers whose approvals may not affect merge requirements

Assignees

No one assigned

Labels

None yet

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

Breadcrumb navigation visibility on mobile/narrow screens

3 participants

@undeMalum @hugovk @m-aciek