Repository navigation
MR approval settings Group Level #3165
Description
Activity
This issue was marked stale because it has been open 60 days with no activity. Please remove the stale label or comment on this issue. Otherwise, it will be closed in 15 days.
As an open-source project, we rely on community contributions to address many of the reported issues. Without a proposed fix or active work towards a solution it is our policy to close inactive issues. This is documented in CONTRIBUTING.rst
How to keep this issue open: * If you are still experiencing this issue and are willing to investigate a fix, please comment and let us know. * If you (or someone else) can propose a pull request with a solution, that would be fantastic. * Any significant update or active discussion indicating progress will also prevent closure.
We value your input. If you can help provide a fix, we'd be happy to keep this issue open and support your efforts.This feature in Gitlab is - as of now - experimental and must be enabled in the admin settings, but I would request it too.
Additionally, this should be implemented on the project-level, too, as this is missing yet.https://docs.gitlab.com/api/merge_request_approval_settings/#project-mr-approval-settings
Reacted by xakepnzCommenting for the bot to ignore the
stalewarning.Reacted by Philip GillißenThis issue was marked stale because it has been open 60 days with
no activity. Please remove the stale label or comment on this
issue. Otherwise, it will be closed in 15 days.As an open-source project, we rely on community contributions to
address many of the reported issues. Without a proposed fix or
active work towards a solution it is our policy to close inactive
issues. This is documented in CONTRIBUTING.rstHow to keep this issue open:
- If you are still experiencing this issue and are willing to
investigate a fix, please comment and let us know. - If you (or someone else) can propose a pull request with a
solution, that would be fantastic. - Any significant update or active discussion indicating progress
will also prevent closure.
We value your input. If you can help provide a fix, we'd be happy
to keep this issue open and support your efforts.This is documented in CONTRIBUTING.rst
https://github.com/python-gitlab/python-gitlab/blob/main/CONTRIBUTING.rst- If you are still experiencing this issue and are willing to
Commenting for the bot to ignore the stale warning.
<@guerda> This feature in Gitlab is - as of now - experimental and must be enabled in the admin settings [...]
What makes you say this is experimental?
https://docs.gitlab.com/api/merge_request_approval_settings/#group-mr-approval-settings has no note of it being experimental. (Page history: https://gitlab.com/gitlab-org/gitlab/-/commits/master/doc/api/merge_request_approval_settings.md)
https://docs.gitlab.com/api/merge_request_approvals/#approval-rules-for-groups is experimental, but that's a different thing.
What makes you say this is experimental?
At the time of my comment, the API for getting and setting project merge request approval settings was experimental. A lot can change in 7 months
Reacted by John VillalovosThis issue was marked stale because it has been open 60 days with
no activity. Please remove the stale label or comment on this
issue. Otherwise, it will be closed in 15 days.As an open-source project, we rely on community contributions to
address many of the reported issues. Without a proposed fix or
active work towards a solution it is our policy to close inactive
issues. This is documented in CONTRIBUTING.rstHow to keep this issue open:
- If you are still experiencing this issue and are willing to
investigate a fix, please comment and let us know. - If you (or someone else) can propose a pull request with a
solution, that would be fantastic. - Any significant update or active discussion indicating progress
will also prevent closure.
We value your input. If you can help provide a fix, we'd be happy
to keep this issue open and support your efforts.This is documented in CONTRIBUTING.rst
https://github.com/python-gitlab/python-gitlab/blob/main/CONTRIBUTING.rst- If you are still experiencing this issue and are willing to
This feature would still be valuable to manage and check group level merge request approval settings
This issue was marked stale because it has been open 60 days with
no activity. Please remove the stale label or comment on this
issue. Otherwise, it will be closed in 15 days.As an open-source project, we rely on community contributions to
address many of the reported issues. Without a proposed fix or
active work towards a solution it is our policy to close inactive
issues. This is documented in CONTRIBUTING.rstHow to keep this issue open:
- If you are still experiencing this issue and are willing to
investigate a fix, please comment and let us know. - If you (or someone else) can propose a pull request with a
solution, that would be fantastic. - Any significant update or active discussion indicating progress
will also prevent closure.
We value your input. If you can help provide a fix, we'd be happy
to keep this issue open and support your efforts.This is documented in CONTRIBUTING.rst
https://github.com/python-gitlab/python-gitlab/blob/main/CONTRIBUTING.rst- If you are still experiencing this issue and are willing to
This feature request is still very much relevant.
This issue was marked stale because it has been open 60 days with
no activity. Please remove the stale label or comment on this
issue. Otherwise, it will be closed in 15 days.As an open-source project, we rely on community contributions to
address many of the reported issues. Without a proposed fix or
active work towards a solution it is our policy to close inactive
issues. This is documented in CONTRIBUTING.rstHow to keep this issue open:
- If you are still experiencing this issue and are willing to
investigate a fix, please comment and let us know. - If you (or someone else) can propose a pull request with a
solution, that would be fantastic. - Any significant update or active discussion indicating progress
will also prevent closure.
We value your input. If you can help provide a fix, we'd be happy
to keep this issue open and support your efforts.This is documented in CONTRIBUTING.rst
https://github.com/python-gitlab/python-gitlab/blob/main/CONTRIBUTING.rst- If you are still experiencing this issue and are willing to
I would still like to see this feature, as I manually crafted the API request myself as a workaround.
This issue was marked stale because it has been open 60 days with
no activity. Please remove the stale label or comment on this
issue. Otherwise, it will be closed in 15 days.As an open-source project, we rely on community contributions to
address many of the reported issues. Without a proposed fix or
active work towards a solution it is our policy to close inactive
issues. This is documented in CONTRIBUTING.rstHow to keep this issue open:
- If you are still experiencing this issue and are willing to
investigate a fix, please comment and let us know. - If you (or someone else) can propose a pull request with a
solution, that would be fantastic. - Any significant update or active discussion indicating progress
will also prevent closure.
We value your input. If you can help provide a fix, we'd be happy
to keep this issue open and support your efforts.This is documented in CONTRIBUTING.rst
https://github.com/python-gitlab/python-gitlab/blob/main/CONTRIBUTING.rst- If you are still experiencing this issue and are willing to
I would still like to see the client supporting the group level merge request settings. Right now I have to send requests manually to the API outside of python-gitlab. Supporting this via the client would be great
Group MR approval settings
Feature Request to create the group-mr-approval-settings object on the Group class.
The ability exists over API to query this:
{ "allow_author_approval": { "value": true, "locked": false, "inherited_from": null }, "allow_committer_approval": { "value": true, "locked": false, "inherited_from": null }, "allow_overrides_to_approver_list_per_merge_request": { "value": true, ...e.g.
ref: https://gitlab.com/gitlab-security-oss/cis/gitlabcis/-/issues/125
Specifications
5.6.0GitLab Enterprise Edition 17.11.0-pre76ac92593a5