Visitar URL original
test: migrate to pytest by spaceone · Pull Request #669 · python-ldap/python-ldap · GitHub
Skip to content

test: migrate to pytest - #669

Open
spaceone wants to merge 4 commits into
mainfrom
pytest-migration
Open

test: migrate to pytest#669
spaceone wants to merge 4 commits into
mainfrom
pytest-migration

Conversation

@spaceone

@spaceone spaceone commented Oct 7, 2026

Copy link
Copy Markdown
Contributor

Issue: #396

spaceone
spaceone commented Oct 7, 2026
View reviewed changes
Comment thread Lib/slapdtest/_slapdtest.py Resolved
@spaceone
spaceone force-pushed the feat/asynchronous-sasl-binds branch from a05d3e2 to 9f2c55b Compare October 9, 2026 19:28
@spaceone
spaceone requested review from droideck and mistotebe and removed request for droideck October 9, 2026 19:51
spaceone
spaceone commented Oct 10, 2026
View reviewed changes
Comment thread Tests/test_bind.py
@@ -1,5 +1,6 @@
import os

@spaceone spaceone Oct 10, 2026

Copy link
Copy Markdown
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Would you be okay with renaming all files to test_-prefix?

@droideck droideck Oct 13, 2026

Copy link
Copy Markdown
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Yeah, test_ makes sense and that's how pytest also discovers things. So I would remove the custom python_files = t_*.py setting and would update the explicit file paths in tox.ini along with the rename.
@mistotebe WDYT?

@spaceone spaceone Oct 13, 2026

Copy link
Copy Markdown
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

OK, I added an additional commit for the rename.

@droideck droideck Oct 21, 2026

Copy link
Copy Markdown
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I think you might forgot to push it :)

@spaceone spaceone Oct 21, 2026

Copy link
Copy Markdown
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Correct, I only pushed it into my local fork. Now it's there.

@spaceone
spaceone force-pushed the pytest-migration branch 2 times, most recently from 30ad414 to 26f2277 Compare October 21, 2026 08:24
@spaceone
spaceone changed the base branch from feat/asynchronous-sasl-binds to main October 21, 2026 08:26
@spaceone spaceone added this to the 3.5.0 milestone Oct 25, 2026
@spaceone
test: migrate to pytest
e50c6a4 
Issue: #396
@spaceone
test: rename test classes
2158420 
to be compliant with pytest defaults

Issue: #396
@spaceone
build(slapdtest): add pytest as optional dependency
fcce111 
Add pytest as an optional dependency/extra for consumers that use the
`slapdtest` module shipped with the package. The ldap package
does not require pytest at runtime.
@spaceone
chore: rename all tests to "test_" prefix
3a3ce88 
for compatibility with standard pytest.

Issue: #396
droideck
droideck approved these changes Nov 13, 2026
View reviewed changes

@droideck droideck left a comment

Copy link
Copy Markdown
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM.
@mistotebe would you also be okay with 3.5 for this change?

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

@droideck droideck droideck approved these changes
@mistotebe mistotebe Awaiting requested review from mistotebe

Assignees

No one assigned

Labels

None yet

Projects

None yet

Milestone

3.5.0

Development

Successfully merging this pull request may close these issues.

2 participants

@spaceone @droideck