Visitar URL original
refactor: nit-pick code cleanup by spaceone · Pull Request #675 · python-ldap/python-ldap · GitHub
Skip to content

refactor: nit-pick code cleanup - #675

Open
spaceone wants to merge 4 commits into
mainfrom
refactor/code-cleanup
Open

refactor: nit-pick code cleanup#675
spaceone wants to merge 4 commits into
mainfrom
refactor/code-cleanup

Conversation

@spaceone

@spaceone spaceone commented Oct 18, 2026

Copy link
Copy Markdown
Contributor 
refactor: nit-pick code cleanup

* use PEP8 conform names
* use enumerate
* rename 1 letter variables to something more meaningful
* re-indent useless else block


style: move `__all__` after imports and add some missing declarations of it

docs: add more docstrings

refactor: rename user facing argument names

Issue: #657

@spaceone
spaceone force-pushed the refactor/code-cleanup branch from 0546c97 to d7b9946 Compare October 18, 2026 13:53
droideck
droideck requested changes Oct 21, 2026
View reviewed changes
Comment thread Lib/ldap/schema/models.py Resolved
Comment thread Lib/ldap/dn.py Resolved
@spaceone
spaceone force-pushed the refactor/code-cleanup branch 7 times, most recently from 7778b21 to 23b2128 Compare October 25, 2026 08:15
@spaceone spaceone added this to the 3.5.0 milestone Oct 25, 2026
@spaceone
spaceone force-pushed the refactor/code-cleanup branch from 23b2128 to 2985b30 Compare October 25, 2026 21:21
@spaceone
spaceone force-pushed the refactor/code-cleanup branch from 2985b30 to 21e0fe5 Compare November 5, 2026 20:27
droideck
droideck requested changes Nov 13, 2026
View reviewed changes
Comment thread Lib/ldap/schema/subentry.py Resolved
Comment thread Lib/ldap/functions.py Resolved
Comment thread Lib/ldap/schema/subentry.py Resolved
@spaceone
refactor: nit-pick code cleanup
139bed5 
* use PEP8 conform names
* use enumerate
* rename 1 letter variables to something more meaningful
* re-indent useless else block

Issue: #657
Issue: #657
@spaceone
refactor(ldap.schema): enhance SubSchema.get_syntax()
a57a754
@spaceone
style: move __all__ after imports and add some missing declarations…
0c22ff0 
… of it

Issue: #657
Issue: #657
@spaceone
docs: add more docstrings
6e502e1 
Issue: #657
Issue: #657
@spaceone
spaceone force-pushed the refactor/code-cleanup branch from 21e0fe5 to 6e502e1 Compare November 13, 2026 19:56
@spaceone
spaceone requested a review from droideck November 13, 2026 19:58
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

@droideck droideck Awaiting requested review from droideck

Requested changes must be addressed to merge this pull request.

Assignees

No one assigned

Labels

None yet

Projects

None yet

Milestone

3.5.0

Development

Successfully merging this pull request may close these issues.

2 participants

@spaceone @droideck