Visitar URL original
Handle empty core-property date elements by GreedyC · Pull Request #1623 · python-openxml/python-docx · GitHub
Skip to content

Handle empty core-property date elements #1623

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Open
GreedyC wants to merge 1 commit into
base: master
Choose a base branch
from
Open

Handle empty core-property date elements #1623

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
2 changes: 2 additions & 0 deletions src/docx/oxml/coreprops.py
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -195,6 +195,8 @@ def _datetime_of_element(self, property_name: str) -> dt.datetime | None:
if element is None:
return None
datetime_str = element.text
if not datetime_str:
return None
try:
return self._parse_W3CDTF_to_datetime(datetime_str)
except ValueError:
Expand Down
17 changes: 17 additions & 0 deletions tests/opc/test_coreprops.py
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -79,6 +79,23 @@ def it_knows_the_date_property_values(
actual_datetime = getattr(core_properties, prop_name)
assert actual_datetime == expected_datetime

@pytest.mark.parametrize(
("prop_name", "tagname"),
[
("created", "dcterms:created"),
("modified", "dcterms:modified"),
("last_printed", "cp:lastPrinted"),
],
)
@pytest.mark.parametrize("value", ["", " ", "not-a-date"])
def it_returns_none_for_empty_or_invalid_date_properties(
self, prop_name: str, tagname: str, value: str
):
xml = self.coreProperties(tagname, value)
core_properties = CoreProperties(cast("CT_CoreProperties", parse_xml(xml)))

assert getattr(core_properties, prop_name) is None

@pytest.mark.parametrize(
("prop_name", "tagname", "value", "str_val", "attrs"),
[
Expand Down