Visitar URL original
Fix tests for Python 3.10 by frenzymadness · Pull Request #336 · python-semver/python-semver · GitHub
Skip to content

Fix tests for Python 3.10 - #336

Merged
tomschr merged 2 commits into
python-semver:maint/v2from
frenzymadness:fix_3.10
Feb 16, 2021
Merged

Fix tests for Python 3.10#336
tomschr merged 2 commits into
python-semver:maint/v2from
frenzymadness:fix_3.10

Conversation

@frenzymadness

@frenzymadness frenzymadness commented Feb 16, 2021

Copy link
Copy Markdown

This simple fix makes tests pass with Python 3.10. Without it, the error is:

453   If the dictionary contains unknown keys, you get a :class:`TypeError` exception::
454 
455     >>> v > dict(major=1, unknown=42)
Differences (ndiff with -expected +actual):
      Traceback (most recent call last):
    - ...
    +   File "/usr/lib64/python3.10/doctest.py", line 1340, in __run
    +     exec(compile(example.source, filename, "single",
    +   File "<doctest usage.rst[75]>", line 1, in <module>
    +     v > dict(major=1, unknown=42)
    +   File "/builddir/build/BUILD/python-semver-2.13.0/semver.py", line 203, in wrapper
    +     return operator(self, other)
    +   File "/builddir/build/BUILD/python-semver-2.13.0/semver.py", line 589, in __gt__
    +     return self.compare(other) > 0
    +   File "/builddir/build/BUILD/python-semver-2.13.0/semver.py", line 495, in compare
    +     other = cls(**other)
    - TypeError: __init__() got an unexpected keyword argument 'unknown'
    + TypeError: VersionInfo.__init__() got an unexpected keyword argument 'unknown'
    ?            ++++++++++++

@tomschr

tomschr commented Feb 16, 2021

Copy link
Copy Markdown
Member

Thanks @frenzymadness, much appreciated! 👍

Just one thing: the main/v2 branch is mostly the maintenance branch for version 2 of semver. Current development happens in the master branch.

I've compared the file docs/usage.rst in master branch and this is how it looks:

>>> v > dict(major=1, unknown=42)
Traceback (most recent call last):
...
TypeError: ... got an unexpected keyword argument 'unknown'

So it's issue is already fixed in master, but looks very similar. Would you like to adapt your changes so it's consistent with the master branch?

Thanks!

tomschr
tomschr requested changes Feb 16, 2021
View reviewed changes

@tomschr tomschr left a comment

Copy link
Copy Markdown
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Here is my suggestion. 🙂

Comment thread docs/usage.rst Resolved
@frenzymadness @tomschr
Update docs/usage.rst
dc6e816 
Co-authored-by: Tom Schraitle <tomschr@users.noreply.github.com>
@frenzymadness

frenzymadness commented Feb 16, 2021

Copy link
Copy Markdown
Author

Your suggestion works as well and it's closer to master branch. We still maintain version 2 as RPM package in Fedora because the current development version lacks a stable release.

@tomschr

tomschr commented Feb 16, 2021

Copy link
Copy Markdown
Member

Thank you! 👍

I hope we can publish a stable release soon.

@tomschr
tomschr merged commit 3809aed into python-semver:maint/v2 Feb 16, 2021
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

@tomschr tomschr tomschr requested changes

Assignees

No one assigned

Labels

None yet

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

2 participants

@frenzymadness @tomschr