Visitar URL original
Add Version class to __all__ export. Fix #410 by Soneji · Pull Request #411 · python-semver/python-semver · GitHub
Skip to content

Add Version class to __all__ export. Fix #410 - #411

Merged
tomschr merged 2 commits into
python-semver:masterfrom
Soneji:patch-1
Jun 14, 2023
Merged

Add Version class to __all__ export. Fix #410#411
tomschr merged 2 commits into
python-semver:masterfrom
Soneji:patch-1

Conversation

@Soneji

@Soneji Soneji commented Jun 14, 2023

Copy link
Copy Markdown
Contributor

No description provided.

tomschr
tomschr requested changes Jun 14, 2023
View reviewed changes

@tomschr tomschr left a comment •
edited
Loading

Copy link
Copy Markdown
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks @Soneji for your contribution! 👍 I have a minor comment, see below.

To avoid formatting errors, call tox -e checks to see if everything is okay. Sometimes black complains about some lines. 😉

Comment thread src/semver/__init__.py Outdated
@Soneji

Soneji commented Jun 14, 2023

Copy link
Copy Markdown
Contributor Author

Looks like the checks have passed. Is this ok to merge?

@tomschr

tomschr commented Jun 14, 2023

Copy link
Copy Markdown
Member

Many thanks for the contribution! 👍

Looks like the checks have passed. Is this ok to merge?

Yes, I can merge it.

@tomschr
tomschr merged commit 17bc257 into python-semver:master Jun 14, 2023
@Soneji

Soneji commented Jun 14, 2023 •
edited
Loading

Copy link
Copy Markdown
Contributor Author

Amazing, thank you so much

Are you able to release and publish a patch for this?

Rocking that contributor badge now 😎

@tomschr

tomschr commented Jun 14, 2023 •
edited
Loading

Copy link
Copy Markdown
Member

Amazing, thank you so much

Thanks for your contribution! ❤️

Are you able to release and publish a patch for this?

Yes, I'm actually planning to create a new release. Not sure if I have time today, but it will be available very soon. I'll let you know. 🙂

@tomschr

tomschr commented Jun 14, 2023

Copy link
Copy Markdown
Member

@Soneji I was able to create it sooner than I thought. 😉 Find all information here (including PyPI):

https://github.com/python-semver/python-semver/releases/tag/3.0.1

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

@tomschr tomschr tomschr requested changes

Assignees

No one assigned

Labels

None yet

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

2 participants

@Soneji @tomschr