Repository navigation
[Dynamo] Fix str(Guard.obj_weakref) bug to re-ennable support overriding __getattr__ - #88564
yanboliang wants to merge 1 commit into
Conversation
🔗 Helpful Links🧪 See artifacts and rendered test results at hud.pytorch.org/pr/88564
Note: Links to docs will display an error until the docs builds have been completed. ❌ 1 FailuresAs of commit d56e79d: This comment was automatically generated by Dr. CI and updates every 15 minutes. |
| @staticmethod | ||
| def weakref_to_str(obj_weakref): | ||
| """ | ||
| This is a workaround of a Python weakref bug. |
There was a problem hiding this comment.
Opened python/cpython#99184 to track this bug at cpython.
|
cpython devs disagree with the assessment that it's a cpython bug, wdyt? Why are we printing weakrefs in the first place? |
I responded on that thread.
I think this is info and debug purpose.
Update: cpython fix is ready - python/cpython#99244. |
ezyang
left a comment
ezyang
left a comment
There was a problem hiding this comment.
link the weakref bug and happy to accept
|
@pytorchbot merge |
Merge startedYour change will be merged once all checks pass (ETA 0-4 Hours). Learn more about merging in the wiki. Questions? Feedback? Please reach out to the PyTorch DevX Team |
Merge failedReason: This PR is too stale; the last push date was more than 3 days ago. Please rebase and try again. You can rebase by leaving the following comment on this PR: Details for Dev Infra teamRaised by workflow job |
|
@pytorchbot merge -f "irrelevant MacOS errors" |
Merge startedYour change will be merged immediately since you used the force (-f) flag, bypassing any CI checks (ETA: 1-5 minutes). Learn more about merging in the wiki. Questions? Feedback? Please reach out to the PyTorch DevX Team |
…ing __getattr__ (pytorch#88564) See my inline comments! Pull Request resolved: pytorch#88564 Approved by: https://github.com/ezyang, https://github.com/anijain2305
…ing __getattr__ (pytorch#88564) See my inline comments! Pull Request resolved: pytorch#88564 Approved by: https://github.com/ezyang, https://github.com/anijain2305
4 participants
See my inline comments!
cc @mlazos @soumith @voznesenskym @penguinwu @anijain2305 @EikanWang @jgong5 @Guobing-Chen @chunyuan-w @XiaobingSuper @zhuhaozhe @blzheng @Xia-Weiwen @wenzhe-nrv @jiayisunx @desertfire