Visitar URL original
Add support for computed property names by rhendric · Pull Request #99 · quintenkasteel/language-javascript · GitHub
Skip to content

Add support for computed property names - #99

Merged
erikd merged 1 commit into
quintenkasteel:new-astfrom
rhendric:submit/computed-property-names
Sep 5, 2019
Merged

erikd merged 1 commit into
quintenkasteel:new-astfrom
rhendric:submit/computed-property-names

Conversation

@rhendric

@rhendric rhendric commented Sep 4, 2019

Copy link
Copy Markdown
Contributor

No description provided.

@rhendric

rhendric commented Sep 4, 2019

Copy link
Copy Markdown
Contributor Author

After this and #98, the remaining PRs I intend to submit (adding support for rest parameters, default arguments, object/array destructuring in parameters, generators/yield, object literal methods, classes, and the super keyword) start to refactor existing AST constructors, instead of merely adding new ones. If you want to make a backwards-compatible-modulo-exhaustiveness-checks release (to be followed by a backwards-incompatible release shortly thereafter), the time to do that is after this and #98 are merged. If you don't think it matters, I have no issue until waiting until the rest of the work is submitted and merged too.

@erikd
erikd merged commit 00775d2 into quintenkasteel:new-ast Sep 5, 2019
@rhendric
rhendric deleted the submit/computed-property-names branch September 5, 2019 06:26
@rhendric rhendric mentioned this pull request Sep 29, 2019
3 of 9 tasks
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants