Visitar URL original
Update test suite to future-proof base images by clue · Pull Request #299 · reactphp/socket · GitHub
Skip to content

Update test suite to future-proof base images - #299

Merged
WyriHaximus merged 1 commit into
reactphp:1.xfrom
clue-labs:runs-on
Oct 15, 2022
Merged

Update test suite to future-proof base images#299
WyriHaximus merged 1 commit into
reactphp:1.xfrom
clue-labs:runs-on

Conversation

@clue

@clue clue commented Oct 6, 2022

Copy link
Copy Markdown
Member

This simple changeset updates the test suite to future-proof base images. Likewise, legacy HHVM is now executed in an up-to-date base image, but using a legacy container instead. This way, we no longer depend on any legacy base images that will be removed in the future as per https://github.blog/changelog/2022-08-09-github-actions-ubuntu-22-04-is-now-generally-available-on-github-hosted-runners/, https://github.blog/changelog/2022-08-09-github-actions-the-ubuntu-18-04-actions-runner-image-is-being-deprecated-and-will-be-removed-by-12-1-22/ and actions/runner-images#6002. I've confirmed pulling container images from Docker Hub does not appear to be rate-limited as per actions/runner-images#1445. Once these changes are merged, we should apply similar updates to all our other components.

Builds on top of #297 and #289

@clue clue added this to the v1.13.0 milestone Oct 6, 2022
@clue
clue requested a review from WyriHaximus October 6, 2022 13:13
WyriHaximus
WyriHaximus reviewed Oct 10, 2022
View reviewed changes
Comment thread .github/workflows/ci.yml Resolved
@clue

clue commented Oct 11, 2022

Copy link
Copy Markdown
Member Author

Updated to work around failing test case for legacy HHVM (trying to allocate 1048576 file descriptors turns out to be a bad idea). This is now ready for review :shipit:

@clue clue mentioned this pull request Oct 11, 2022
Merged
@clue
clue force-pushed the runs-on branch 2 times, most recently from a8cf6ac to 73db2a9 Compare October 12, 2022 09:55
@clue

clue commented Oct 12, 2022

Copy link
Copy Markdown
Member Author

I've just updated this to use actions/checkout@v3 instead of v1 and only use the legacy HHVM container to run Composer and PHPUnit (also refs https://github.blog/changelog/2022-10-11-github-actions-deprecating-save-state-and-set-output-commands/ and https://github.blog/changelog/2022-09-22-github-actions-all-actions-will-begin-running-on-node16-instead-of-node12/). This is now ready for review (again) :shipit:

@clue
clue requested a review from WyriHaximus October 12, 2022 13:31
This was referenced Oct 12, 2022
Merged
Merged
WyriHaximus
WyriHaximus approved these changes Oct 15, 2022
View reviewed changes

@WyriHaximus WyriHaximus left a comment

Copy link
Copy Markdown
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks for the updates, looks even better now 👍 .

@WyriHaximus
WyriHaximus merged commit 8397f22 into reactphp:1.x Oct 15, 2022
@clue
clue deleted the runs-on branch October 16, 2022 09:45
This was referenced Oct 19, 2022
Merged
Merged
Merged
Merged
Merged
This was referenced Oct 26, 2022
Merged
Merged
Merged
Merged
Merged
This was referenced Oct 30, 2022
Merged
Merged
Merged
This was referenced Nov 13, 2022
Merged
Merged
Merged
Merged
Merged
Merged
Merged
Merged
This was referenced Jan 30, 2023
Merged
Merged
This was referenced Feb 21, 2023
Merged
Merged
Merged
Merged
This was referenced Mar 2, 2023
Merged
Merged
@clue clue mentioned this pull request Mar 15, 2023
Merged
@clue clue mentioned this pull request Jun 6, 2023
Merged
@clue clue mentioned this pull request Aug 25, 2023
Merged
@clue clue mentioned this pull request Oct 26, 2023
Merged
@SimonFrings SimonFrings mentioned this pull request Nov 2, 2023
Merged
This was referenced Nov 15, 2023
Merged
Merged
@clue clue mentioned this pull request Dec 6, 2024
Merged
@clue clue mentioned this pull request Dec 24, 2024
Merged
@clue clue mentioned this pull request Apr 18, 2025
Merged
@PaulRotmann PaulRotmann mentioned this pull request Jun 23, 2025
Closed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

@WyriHaximus WyriHaximus WyriHaximus approved these changes
@SimonFrings SimonFrings SimonFrings approved these changes

Assignees

No one assigned

Labels

maintenance

Projects

None yet

Milestone

v1.13.0

Development

Successfully merging this pull request may close these issues.

3 participants

@clue @WyriHaximus @SimonFrings