Visitar URL original
Bump 8.8 image by uglide · Pull Request #499 · redis/NRedisStack · GitHub
Skip to content

Bump 8.8 image #499

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Closed
uglide wants to merge 1 commit into from
Closed

Bump 8.8 image #499

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
2 changes: 1 addition & 1 deletion tests/dockers/.env.v8.8
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -2,4 +2,4 @@
# Used by the run-tests GitHub Action

# Redis CE image version (Redis 8+ includes modules natively)
CLIENT_LIBS_TEST_IMAGE=redislabs/client-libs-test:8.8-rc1
CLIENT_LIBS_TEST_IMAGE=redislabs/client-libs-test:custom-26235535976-debian

@cursor cursor Bot May 25, 2026

Copy link
Copy Markdown

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Custom CI build image used as permanent default

Medium Severity

The image tag custom-26235535976-debian appears to be a transient CI build artifact (the numeric portion resembles a GitHub Actions run ID), unlike every other version which uses stable release tags (e.g., 8.6.3, 8.4.3). If this custom image is cleaned up from the registry, all CI runs using the v8.8 profile — and any run not specifying an env file (since docker-compose.yml defaults were also changed) — will fail. This looks like a temporary testing reference that may not be intended for permanent commit.

Additional Locations (2)
Fix in Cursor Fix in Web

Reviewed by Cursor Bugbot for commit bd096b1. Configure here.

4 changes: 2 additions & 2 deletions tests/dockers/docker-compose.yml
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -3,7 +3,7 @@
services:

redis:
image: ${CLIENT_LIBS_TEST_IMAGE:-redislabs/client-libs-test:8.8-rc1}
image: ${CLIENT_LIBS_TEST_IMAGE:-redislabs/client-libs-test:custom-26235535976-debian}
container_name: redis-standalone
environment:
- TLS_ENABLED=yes
Expand All @@ -21,7 +21,7 @@ services:
- all

cluster:
image: ${CLIENT_LIBS_TEST_IMAGE:-redislabs/client-libs-test:8.8-rc1}
image: ${CLIENT_LIBS_TEST_IMAGE:-redislabs/client-libs-test:custom-26235535976-debian}
container_name: redis-cluster
environment:
- REDIS_CLUSTER=yes
Expand Down
Loading