Visitar URL original
Realistic noise simulation by shrapp · Pull Request #1576 · rigetti/pyquil · GitHub
Skip to content

Realistic noise simulation - #1576

Open
shrapp wants to merge 21 commits into
rigetti:masterfrom
shrapp:master
Open

Realistic noise simulation#1576
shrapp wants to merge 21 commits into
rigetti:masterfrom
shrapp:master

Conversation

@shrapp

@shrapp shrapp commented May 18, 2023

Copy link
Copy Markdown

Description

A new realistic noise simulation of Rigetti’s QPU implemented in addition to former features in noise.py

Checklist

  • [v] The PR targets the master branch
  • [v] The above description motivates these changes.
  • [v] The change is atomic and can be described by a single commit (your PR will be squashed on merge).
  • All changes to code are covered via unit tests.
  • [v] Parameters and return values have type hints with PEP 484 syntax.
  • Functions and classes have useful Sphinx-style docstrings.
  • (New Feature) The docs have been updated accordingly.
  • (Bugfix) The associated issue is referenced above using auto-close keywords.

@shrapp
shrapp requested a review from a team as a code owner May 18, 2023 22:06
@shrapp

shrapp commented May 18, 2023

Copy link
Copy Markdown
Author

@MarquessV

@MarquessV

MarquessV commented May 23, 2023

Copy link
Copy Markdown
Contributor

Awesome! I've given this a partial review and left some comments, will do another pass later in the week.

MarquessV
MarquessV reviewed Jun 5, 2023
View reviewed changes
Comment thread pyquil/noise.py Resolved
Comment thread pyquil/noise.py Resolved
Comment thread pyquil/noise.py Resolved
Comment thread pyquil/noise.py Resolved
Comment thread pyquil/noise.py Resolved
Comment thread pyquil/noise.py Resolved
shrapp and others added 4 commits June 9, 2023 13:11
@shrapp @MarquessV
Update pyquil/noise.py
73e127a 
Co-authored-by: Marquess Valdez <marquessavaldez@gmail.com>
@shrapp @MarquessV
Update pyquil/noise.py
4b1810c 
Co-authored-by: Marquess Valdez <marquessavaldez@gmail.com>
@shrapp
fix to use isa instead of http for calibration
708ff9b
@shrapp
Merge branch 'master' into master
aeddc41
@shrapp

shrapp commented Aug 29, 2023

Copy link
Copy Markdown
Author

Hi @MarquessV, sorry for the delay. I have just fixed all of your comments and I hope it is ready for push. Thanks!

@shrapp
shrapp requested a review from MarquessV September 3, 2023 20:58

This branch has not been deployed

No deployments
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

@MarquessV MarquessV Awaiting requested review from MarquessV

At least 1 approving review is required to merge this pull request.

Assignees

No one assigned

Labels

None yet

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

2 participants

@shrapp @MarquessV