Visitar URL original
feat: `new URL(..., import.meta.url)` support by hyfdev · Pull Request #2710 · rolldown/rolldown · GitHub
Skip to content

feat: new URL(..., import.meta.url) support - #2710

Merged
hyfdev merged 2 commits into
mainfrom
11-13-feat_new_url_._import.meta.url_support
Nov 13, 2024
Merged

feat: new URL(..., import.meta.url) support#2710
hyfdev merged 2 commits into
mainfrom
11-13-feat_new_url_._import.meta.url_support

Conversation

@hyfdev

@hyfdev hyfdev commented Nov 12, 2024

Copy link
Copy Markdown
Member

Description

@hyfdev
hyfdev marked this pull request as ready for review November 12, 2024 22:43
@hyfdev Graphite App

hyfdev commented Nov 12, 2024

Copy link
Copy Markdown
Member Author

This stack of pull requests is managed by Graphite. Learn more about stacking.

Join @hyf0 and the rest of your teammates on Graphite Graphite

@netlify

netlify Bot commented Nov 12, 2024 •
edited
Loading

Copy link
Copy Markdown

✅ Deploy Preview for rolldown-rs canceled.

Name Link
🔨 Latest commit b5e62a9
🔍 Latest deploy log https://app.netlify.com/sites/rolldown-rs/deploys/67346a0b49a00a0008d77eb0

@hyfdev
hyfdev force-pushed the 11-13-feat_new_url_._import.meta.url_support branch from 8001a1f to b26cf63 Compare November 12, 2024 22:45
@github-actions

github-actions Bot commented Nov 12, 2024 •
edited
Loading

Copy link
Copy Markdown
Contributor

Benchmarks Rust

  • target: main(8ff583f)
  • pr: 11-13-feat_new_url_._import.meta.url_support(b5e62a9)
group                                                               pr                                     target
-----                                                               --                                     ------
bundle/bundle@multi-duplicated-top-level-symbol                     1.00     61.7±1.61ms        ? ?/sec    1.00     61.8±1.23ms        ? ?/sec
bundle/bundle@multi-duplicated-top-level-symbol-minify              1.00     85.8±0.82ms        ? ?/sec    1.04     89.5±1.66ms        ? ?/sec
bundle/bundle@multi-duplicated-top-level-symbol-minify-sourcemap    1.00    101.1±1.01ms        ? ?/sec    1.03    104.3±2.27ms        ? ?/sec
bundle/bundle@multi-duplicated-top-level-symbol-sourcemap           1.00     68.6±0.72ms        ? ?/sec    1.03     70.6±2.43ms        ? ?/sec
bundle/bundle@rome-ts                                               1.00    109.4±1.03ms        ? ?/sec    1.01    110.0±1.12ms        ? ?/sec
bundle/bundle@rome-ts-minify                                        1.03    210.8±3.85ms        ? ?/sec    1.00    205.0±2.23ms        ? ?/sec
bundle/bundle@rome-ts-minify-sourcemap                              1.02    250.9±1.67ms        ? ?/sec    1.00    245.6±7.41ms        ? ?/sec
bundle/bundle@rome-ts-sourcemap                                     1.00    123.7±0.98ms        ? ?/sec    1.00    123.9±1.60ms        ? ?/sec
bundle/bundle@threejs                                               1.02     37.4±2.20ms        ? ?/sec    1.00     36.7±1.72ms        ? ?/sec
bundle/bundle@threejs-minify                                        1.00     94.7±0.51ms        ? ?/sec    1.01     95.9±0.55ms        ? ?/sec
bundle/bundle@threejs-minify-sourcemap                              1.00    109.5±1.16ms        ? ?/sec    1.01    110.4±1.87ms        ? ?/sec
bundle/bundle@threejs-sourcemap                                     1.00     44.3±0.46ms        ? ?/sec    1.02     45.2±0.47ms        ? ?/sec
bundle/bundle@threejs10x                                            1.00    389.3±3.85ms        ? ?/sec    1.01    394.0±4.71ms        ? ?/sec
bundle/bundle@threejs10x-minify                                     1.00   1218.0±7.97ms        ? ?/sec    1.03  1250.4±12.97ms        ? ?/sec
bundle/bundle@threejs10x-minify-sourcemap                           1.00  1442.7±23.02ms        ? ?/sec    1.01  1462.3±15.29ms        ? ?/sec
bundle/bundle@threejs10x-sourcemap                                  1.00    447.7±5.45ms        ? ?/sec    1.02    455.0±8.78ms        ? ?/sec
remapping/remapping                                                 1.00     28.3±0.38ms        ? ?/sec    1.03     29.1±0.33ms        ? ?/sec
remapping/render-chunk-remapping                                    1.00     68.9±0.36ms        ? ?/sec    1.00     69.1±1.39ms        ? ?/sec
scan/scan@rome-ts                                                   1.00     87.9±1.27ms        ? ?/sec    1.01     88.7±1.05ms        ? ?/sec
scan/scan@threejs                                                   1.00     27.5±1.60ms        ? ?/sec    1.00     27.4±0.88ms        ? ?/sec
scan/scan@threejs10x                                                1.00    279.6±2.55ms        ? ?/sec    1.02    284.0±3.78ms        ? ?/sec

IWANABETHATGUY
IWANABETHATGUY reviewed Nov 13, 2024
View reviewed changes
Comment thread crates/rolldown/src/ast_scanner/new_url.rs Resolved
IWANABETHATGUY
IWANABETHATGUY reviewed Nov 13, 2024
View reviewed changes
Comment thread crates/rolldown/src/ast_scanner/new_url.rs Resolved
IWANABETHATGUY
IWANABETHATGUY reviewed Nov 13, 2024
View reviewed changes
Comment thread crates/rolldown/src/module_finalizers/scope_hoisting/mod.rs Resolved
@magic-akari

magic-akari commented Nov 13, 2024

Copy link
Copy Markdown
Contributor

TODO:

@IWANABETHATGUY IWANABETHATGUY mentioned this pull request Nov 13, 2024
Closed
@IWANABETHATGUY

IWANABETHATGUY commented Nov 13, 2024

Copy link
Copy Markdown
Member

TODO:

Thank you for pointing that out.

@hyfdev
hyfdev force-pushed the 11-13-feat_new_url_._import.meta.url_support branch 2 times, most recently from c4cafe5 to 146ebcf Compare November 13, 2024 06:35
@hyfdev
hyfdev force-pushed the 11-13-feat_new_url_._import.meta.url_support branch from 146ebcf to 152d84e Compare November 13, 2024 06:36
@hyfdev
hyfdev enabled auto-merge November 13, 2024 06:36
@hyfdev
hyfdev force-pushed the 11-13-feat_new_url_._import.meta.url_support branch from 6a6cd4c to b5e62a9 Compare November 13, 2024 08:57
@hyfdev
hyfdev added this pull request to the merge queue Nov 13, 2024
@github-merge-queue
github-merge-queue Bot removed this pull request from the merge queue due to failed status checks Nov 13, 2024
@hyfdev
hyfdev added this pull request to the merge queue Nov 13, 2024
Merged via the queue into main with commit 7c6cbb2 Nov 13, 2024
@hyfdev
hyfdev deleted the 11-13-feat_new_url_._import.meta.url_support branch November 13, 2024 09:24
@valadaptive valadaptive mentioned this pull request Jan 23, 2026
Merged
hyfdev pushed a commit that referenced this pull request Jan 26, 2026
@valadaptive
fix(rust): use ModuleType::Asset for new URL imports (#8035)
70fb97f 
Resolves #7894.

#2710 introduced
`asserted_module_type`, but didn't actually use it when loading the
module. This meant we were always loading it as a string, only
overriding the module type *after* loading it.
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

@IWANABETHATGUY IWANABETHATGUY IWANABETHATGUY approved these changes

Assignees

No one assigned

Labels

needs-triage

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

3 participants

@hyfdev @magic-akari @IWANABETHATGUY