Repository navigation
Conversation
|
Thank you @cyberhck for contributing this PR. |
|
I've reviewed, I'm very new to the codebase (first contrib), but it was helped with LLM (I have used it as a flashlight, to debug what went wrong what is the call site, and how to fix), please let me know if I'm missing something or something needs to be added. Happy to change. Basically any dataset that someone might have convention for: this PR attempts to retain the original data from config and then if the dataset exists, tries to use that instead. |
|
hello team, is there anything we can do about this? |
Description
Preserve an explicitly configured BigQuery dataset ID when that exact dataset already exists.
The warehouse namespace builder snake-cases custom namespaces before the BigQuery manager is created.
bq_events_zm_dev_dts_euwe1, for example, becomesbq_events_zm_dev_dts_euwe_1due to its letter-to-digit boundary. The BigQuery setup path now checks the original configured dataset after establishing its client. If it exists, subsequent schema management and load operations use it verbatim. If it does not exist, the existing sanitised namespace behaviour remains unchanged.Added regression coverage for the exact letter/digit case, absent datasets, both datasets existing, and failed/no-op checks.
Linear Ticket
No linear provided, but I have filed a support ticket for a finding, this would solve that (I think)
Security
New behavior