Visitar URL original
rustdoc: format arrays differently than slices in search results by lolbinarycat · Pull Request #162157 · rust-lang/rust · GitHub
Skip to content

rustdoc: format arrays differently than slices in search results - #162157

Open
lolbinarycat wants to merge 1 commit into
rust-lang:mainfrom
lolbinarycat:rustdoc-array-preview
Open

rustdoc: format arrays differently than slices in search results#162157
lolbinarycat wants to merge 1 commit into
rust-lang:mainfrom
lolbinarycat:rustdoc-array-preview

Conversation

@lolbinarycat

@lolbinarycat lolbinarycat commented Sep 1, 2026

Copy link
Copy Markdown
Contributor

before:
image

after:
image

i want to improve this further, but that would require storing const generics in rustdoc somehow.

r? @GuillaumeGomez

@rustbot

rustbot commented Sep 1, 2026

Copy link
Copy Markdown
Collaborator

Some changes occurred in HTML/CSS/JS.

cc @GuillaumeGomez

@rustbot rustbot added A-rustdoc-js Area: Rustdoc's JS front-end A-rustdoc-search Area: Rustdoc's search feature S-waiting-on-review Status: Awaiting review from the assignee but also interested parties. T-rustdoc Relevant to the rustdoc team, which will review and decide on the PR/issue. T-rustdoc-frontend Relevant to the rustdoc-frontend team, which will review and decide on the web UI/UX output. labels Sep 1, 2026
@GuillaumeGomez

GuillaumeGomez commented Sep 2, 2026

Copy link
Copy Markdown
Member

Thanks!

Please add a rustdoc-js regression test too please.

@lolbinarycat

lolbinarycat commented Sep 2, 2026

Copy link
Copy Markdown
Contributor Author

Best I can tell, the rustdoc-js test suite doesn't quite have the info we need, and none of the other logic of this kind has a test, execept for the very basics of function signature preview in search-about-this-result.goml. do you want me to add it there?

@GuillaumeGomez

GuillaumeGomez commented Sep 2, 2026

Copy link
Copy Markdown
Member

Yes please! Maybe a rendered field or something along the line?

@fmease fmease added S-waiting-on-author Status: This is awaiting some action (such as code changes or more information) from the author. and removed S-waiting-on-review Status: Awaiting review from the assignee but also interested parties. labels Nov 2, 2026

This branch has not been deployed

No deployments
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

@GuillaumeGomez GuillaumeGomez GuillaumeGomez approved these changes

Assignees

@GuillaumeGomez GuillaumeGomez

Labels

A-rustdoc-js Area: Rustdoc's JS front-end A-rustdoc-search Area: Rustdoc's search feature S-waiting-on-author Status: This is awaiting some action (such as code changes or more information) from the author. T-rustdoc Relevant to the rustdoc team, which will review and decide on the PR/issue. T-rustdoc-frontend Relevant to the rustdoc-frontend team, which will review and decide on the web UI/UX output.

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

4 participants

@lolbinarycat @rustbot @GuillaumeGomez @fmease