Visitar URL original
simplify `fluent_value_from_str_list_sep_by_and` by cyrgani · Pull Request #165912 · rust-lang/rust · GitHub
Skip to content

simplify fluent_value_from_str_list_sep_by_and - #165912

Open
cyrgani wants to merge 2 commits into
rust-lang:mainfrom
cyrgani:english-list-only
Open

simplify fluent_value_from_str_list_sep_by_and#165912
cyrgani wants to merge 2 commits into
rust-lang:mainfrom
cyrgani:english-list-only

Conversation

@cyrgani

@cyrgani cyrgani commented Nov 13, 2026

Copy link
Copy Markdown
Contributor

Since the translation effort has stopped, we don't need to support list formatting in other languages at the moment. This allows removing multiple dependencies entirely and removes the last usage of rustc_baked_icu_data.

@cyrgani
simplify fluent_value_from_str_list_sep_by_and
9926bdc 
Since the translation effort has stopped, we don't need to support list formatting in other languages at the moment. This allows removing multiple dependencies entirely and removes the last usage of `rustc_baked_icu_data`.
@rustbot

rustbot commented Nov 13, 2026

Copy link
Copy Markdown
Collaborator

rustc_error_messages was changed

cc @TaKO8Ki

The list of allowed third-party dependencies may have been modified! You must ensure that any new dependencies have compatible licenses before merging.

cc @davidtwco, @BoxyUwU

These commits modify the Cargo.lock file. Unintentional changes to Cargo.lock can be introduced when switching branches and rebasing PRs.

If this was unintentional then you should revert the changes before this PR is merged.
Otherwise, you can ignore this comment.

@rustbot rustbot added A-tidy Area: The tidy tool A-translation Area: Translation infrastructure, and migrating existing diagnostics to SessionDiagnostic S-waiting-on-review Status: Awaiting review from the assignee but also interested parties. T-bootstrap Relevant to the bootstrap subteam: Rust's build system (x.py and src/bootstrap) T-compiler Relevant to the compiler team, which will review and decide on the PR/issue. labels Nov 13, 2026
@rustbot

rustbot commented Nov 13, 2026

Copy link
Copy Markdown
Collaborator

r? @davidtwco

rustbot has assigned @davidtwco.
They will have a look at your PR within the next two weeks and either review your PR or reassign to another reviewer.

Use r? to explicitly pick a reviewer

Why was this reviewer chosen?

The reviewer was selected based on:

  • Owners of files modified in this PR: compiler
  • compiler expanded to 79 candidates
  • Random selection from 20 candidates

@cyrgani

cyrgani commented Nov 13, 2026

Copy link
Copy Markdown
Contributor Author

This also removes some transitive dependencies from the compiler that are still used in other parts of the repo and stay in the Cargo.lock. For me, rustc-main has 341 deps on main and 322 after this PR.

@rust-log-analyzer

This comment has been minimized.

Sign in to view

This branch has not been deployed

No deployments
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

No reviews

Assignees

@davidtwco davidtwco

Labels

A-tidy Area: The tidy tool A-translation Area: Translation infrastructure, and migrating existing diagnostics to SessionDiagnostic S-waiting-on-review Status: Awaiting review from the assignee but also interested parties. T-bootstrap Relevant to the bootstrap subteam: Rust's build system (x.py and src/bootstrap) T-compiler Relevant to the compiler team, which will review and decide on the PR/issue.

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

4 participants

@cyrgani @rustbot @rust-log-analyzer @davidtwco