Visitar URL original
hack/build-image: Remove an extra new line after import by anoopcs9 · Pull Request #237 · samba-in-kubernetes/samba-container · GitHub
Skip to content

hack/build-image: Remove an extra new line after import - #237

Merged
mergify[bot] merged 1 commit into
samba-in-kubernetes:masterfrom
anoopcs9:fix-black-format-error
Jan 19, 2026
Merged

hack/build-image: Remove an extra new line after import#237
mergify[bot] merged 1 commit into
samba-in-kubernetes:masterfrom
anoopcs9:fix-black-format-error

Conversation

@anoopcs9

@anoopcs9 anoopcs9 commented Jan 19, 2026

Copy link
Copy Markdown
Collaborator

A new black release with always_one_newline_after_import rule is causing failure with the build-image script.

@anoopcs9
hack/build-image: Remove an extra new line after import
ba7ace9 
A new black release[1] with 'always_one_newline_after_import'[2] rule is
causing failure with the build-image script.

[1] https://github.com/psf/black/releases/tag/26.1.0
[2] psf/black#4489

Signed-off-by: Anoop C S <anoopcs@samba.org>
@mergify mergify Bot added the queued label Jan 19, 2026
@mergify
mergify Bot merged commit 656f4c1 into samba-in-kubernetes:master Jan 19, 2026
49 checks passed
@mergify

mergify Bot commented Jan 19, 2026

Copy link
Copy Markdown

Merge Queue Status

✅ The pull request has been merged at ba7ace9

This pull request spent 6 seconds in the queue, with no time running CI.
The checks were run in-place.

Required conditions to merge
  • #approved-reviews-by >= 1 [🛡 GitHub branch protection]
  • #changes-requested-reviews-by = 0 [🛡 GitHub branch protection]
  • any of [🛡 GitHub branch protection]:
    • check-success = checks
    • check-neutral = checks
    • check-skipped = checks
  • any of [🛡 GitHub branch protection]:
    • check-success = test-ad-server-kubernetes (default, fedora, amd64)
    • check-neutral = test-ad-server-kubernetes (default, fedora, amd64)
    • check-skipped = test-ad-server-kubernetes (default, fedora, amd64)
  • any of [🛡 GitHub branch protection]:
    • check-success = test-ad-server-kubernetes (default, opensuse, amd64)
    • check-neutral = test-ad-server-kubernetes (default, opensuse, amd64)
    • check-skipped = test-ad-server-kubernetes (default, opensuse, amd64)
  • any of [🛡 GitHub branch protection]:
    • check-success = test-ad-server-kubernetes (nightly, centos, amd64)
    • check-neutral = test-ad-server-kubernetes (nightly, centos, amd64)
    • check-skipped = test-ad-server-kubernetes (nightly, centos, amd64)
  • any of [🛡 GitHub branch protection]:
    • check-success = test-ad-server-kubernetes (nightly, fedora, amd64)
    • check-neutral = test-ad-server-kubernetes (nightly, fedora, amd64)
    • check-skipped = test-ad-server-kubernetes (nightly, fedora, amd64)
  • any of [🛡 GitHub branch protection]:
    • check-success = test-server (nightly, centos, amd64)
    • check-neutral = test-server (nightly, centos, amd64)
    • check-skipped = test-server (nightly, centos, amd64)
  • any of [🛡 GitHub branch protection]:
    • check-success = test-server (nightly, fedora, amd64)
    • check-neutral = test-server (nightly, fedora, amd64)
    • check-skipped = test-server (nightly, fedora, amd64)
  • any of [🛡 GitHub branch protection]:
    • check-success = test-server (default, opensuse, amd64)
    • check-neutral = test-server (default, opensuse, amd64)
    • check-skipped = test-server (default, opensuse, amd64)
  • any of [🛡 GitHub branch protection]:
    • check-success = test-server (default, centos, amd64)
    • check-neutral = test-server (default, centos, amd64)
    • check-skipped = test-server (default, centos, amd64)
  • any of [🛡 GitHub branch protection]:
    • check-success = test-server (default, fedora, amd64)
    • check-neutral = test-server (default, fedora, amd64)
    • check-skipped = test-server (default, fedora, amd64)
  • any of [🛡 GitHub branch protection]:
    • check-success = build-toolbox (centos, amd64)
    • check-neutral = build-toolbox (centos, amd64)
    • check-skipped = build-toolbox (centos, amd64)
  • any of [🛡 GitHub branch protection]:
    • check-success = build-toolbox (fedora, amd64)
    • check-neutral = build-toolbox (fedora, amd64)
    • check-skipped = build-toolbox (fedora, amd64)
  • any of [🛡 GitHub branch protection]:
    • check-success = build-toolbox (opensuse, amd64)
    • check-neutral = build-toolbox (opensuse, amd64)
    • check-skipped = build-toolbox (opensuse, amd64)
  • any of [🛡 GitHub branch protection]:
    • check-success = test-server (ceph20, centos, amd64)
    • check-neutral = test-server (ceph20, centos, amd64)
    • check-skipped = test-server (ceph20, centos, amd64)
  • any of [🛡 GitHub branch protection]:
    • check-success = test-server (devbuilds, centos, amd64)
    • check-neutral = test-server (devbuilds, centos, amd64)
    • check-skipped = test-server (devbuilds, centos, amd64)
  • any of [🛡 GitHub branch protection]:
    • check-success = build-client (centos, amd64)
    • check-neutral = build-client (centos, amd64)
    • check-skipped = build-client (centos, amd64)
  • any of [🛡 GitHub branch protection]:
    • check-success = build-client (centos, arm64)
    • check-neutral = build-client (centos, arm64)
    • check-skipped = build-client (centos, arm64)
  • any of [🛡 GitHub branch protection]:
    • check-success = build-client (fedora, amd64)
    • check-neutral = build-client (fedora, amd64)
    • check-skipped = build-client (fedora, amd64)
  • any of [🛡 GitHub branch protection]:
    • check-success = build-client (fedora, arm64)
    • check-neutral = build-client (fedora, arm64)
    • check-skipped = build-client (fedora, arm64)
  • any of [🛡 GitHub branch protection]:
    • check-success = build-client (opensuse, amd64)
    • check-neutral = build-client (opensuse, amd64)
    • check-skipped = build-client (opensuse, amd64)
  • any of [🛡 GitHub branch protection]:
    • check-success = build-client (opensuse, arm64)
    • check-neutral = build-client (opensuse, arm64)
    • check-skipped = build-client (opensuse, arm64)
  • any of [🛡 GitHub branch protection]:
    • check-success = build-ad-server (default, fedora, amd64)
    • check-neutral = build-ad-server (default, fedora, amd64)
    • check-skipped = build-ad-server (default, fedora, amd64)
  • any of [🛡 GitHub branch protection]:
    • check-success = build-ad-server (default, fedora, arm64)
    • check-neutral = build-ad-server (default, fedora, arm64)
    • check-skipped = build-ad-server (default, fedora, arm64)
  • any of [🛡 GitHub branch protection]:
    • check-success = build-ad-server (default, opensuse, amd64)
    • check-neutral = build-ad-server (default, opensuse, amd64)
    • check-skipped = build-ad-server (default, opensuse, amd64)
  • any of [🛡 GitHub branch protection]:
    • check-success = build-ad-server (default, opensuse, arm64)
    • check-neutral = build-ad-server (default, opensuse, arm64)
    • check-skipped = build-ad-server (default, opensuse, arm64)
  • any of [🛡 GitHub branch protection]:
    • check-success = build-ad-server (nightly, centos, amd64)
    • check-neutral = build-ad-server (nightly, centos, amd64)
    • check-skipped = build-ad-server (nightly, centos, amd64)
  • any of [🛡 GitHub branch protection]:
    • check-success = build-ad-server (nightly, centos, arm64)
    • check-neutral = build-ad-server (nightly, centos, arm64)
    • check-skipped = build-ad-server (nightly, centos, arm64)
  • any of [🛡 GitHub branch protection]:
    • check-success = build-ad-server (nightly, fedora, amd64)
    • check-neutral = build-ad-server (nightly, fedora, amd64)
    • check-skipped = build-ad-server (nightly, fedora, amd64)
  • any of [🛡 GitHub branch protection]:
    • check-success = build-ad-server (nightly, fedora, arm64)
    • check-neutral = build-ad-server (nightly, fedora, arm64)
    • check-skipped = build-ad-server (nightly, fedora, arm64)
  • any of [🛡 GitHub branch protection]:
    • check-success = build-server (ceph20, centos, amd64)
    • check-neutral = build-server (ceph20, centos, amd64)
    • check-skipped = build-server (ceph20, centos, amd64)
  • any of [🛡 GitHub branch protection]:
    • check-success = build-server (ceph20, centos, arm64)
    • check-neutral = build-server (ceph20, centos, arm64)
    • check-skipped = build-server (ceph20, centos, arm64)
  • any of [🛡 GitHub branch protection]:
    • check-success = build-server (default, centos, amd64)
    • check-neutral = build-server (default, centos, amd64)
    • check-skipped = build-server (default, centos, amd64)
  • any of [🛡 GitHub branch protection]:
    • check-success = build-server (default, centos, arm64)
    • check-neutral = build-server (default, centos, arm64)
    • check-skipped = build-server (default, centos, arm64)
  • any of [🛡 GitHub branch protection]:
    • check-success = build-server (default, fedora, amd64)
    • check-neutral = build-server (default, fedora, amd64)
    • check-skipped = build-server (default, fedora, amd64)
  • any of [🛡 GitHub branch protection]:
    • check-success = build-server (default, fedora, arm64)
    • check-neutral = build-server (default, fedora, arm64)
    • check-skipped = build-server (default, fedora, arm64)
  • any of [🛡 GitHub branch protection]:
    • check-success = build-server (default, opensuse, amd64)
    • check-neutral = build-server (default, opensuse, amd64)
    • check-skipped = build-server (default, opensuse, amd64)
  • any of [🛡 GitHub branch protection]:
    • check-success = build-server (default, opensuse, arm64)
    • check-neutral = build-server (default, opensuse, arm64)
    • check-skipped = build-server (default, opensuse, arm64)
  • any of [🛡 GitHub branch protection]:
    • check-success = build-server (devbuilds, centos, amd64)
    • check-neutral = build-server (devbuilds, centos, amd64)
    • check-skipped = build-server (devbuilds, centos, amd64)
  • any of [🛡 GitHub branch protection]:
    • check-success = build-server (devbuilds, centos, arm64)
    • check-neutral = build-server (devbuilds, centos, arm64)
    • check-skipped = build-server (devbuilds, centos, arm64)
  • any of [🛡 GitHub branch protection]:
    • check-success = build-server (nightly, centos, amd64)
    • check-neutral = build-server (nightly, centos, amd64)
    • check-skipped = build-server (nightly, centos, amd64)
  • any of [🛡 GitHub branch protection]:
    • check-success = build-server (nightly, centos, arm64)
    • check-neutral = build-server (nightly, centos, arm64)
    • check-skipped = build-server (nightly, centos, arm64)
  • any of [🛡 GitHub branch protection]:
    • check-success = build-server (nightly, fedora, amd64)
    • check-neutral = build-server (nightly, fedora, amd64)
    • check-skipped = build-server (nightly, fedora, amd64)
  • any of [🛡 GitHub branch protection]:
    • check-success = build-server (nightly, fedora, arm64)
    • check-neutral = build-server (nightly, fedora, arm64)
    • check-skipped = build-server (nightly, fedora, arm64)

@mergify mergify Bot removed the queued label Jan 19, 2026
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

@synarete synarete synarete approved these changes
@avanthakkar avanthakkar avanthakkar approved these changes
@phlogistonjohn phlogistonjohn Awaiting requested review from phlogistonjohn

Assignees

No one assigned

Labels

None yet

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

3 participants

@anoopcs9 @synarete @avanthakkar