Repository navigation
Add hello world example and check to tests - #215
Merged
Merged
Conversation
As Python2 doesn't have extended unpacking (c.f. PEP 3132) the unpacking in the example needs to be changed to pass the CI
matthewfeickert
added
feat/enhancement
matthewfeickert
changed the title
matthewfeickert
force-pushed
the
docs/add-hello-world-example-and-check
branch
from
August 26, 2018 01:23
a590513 to
519f99e
Compare
This is done by explicitly calling doctest on the README in the docs section of the CI. This is done instead of adding the README to --doctest-glob in pytest.ini so as to keep the example in the README displaying Python3 code.
Contributor
|
Extended Upacking is a python 3 feature only. Just need to fix |
kratsg
approved these changes
Aug 26, 2018
matthewfeickert
force-pushed
the
docs/add-hello-world-example-and-check
branch
from
August 26, 2018 01:28
519f99e to
09c04da
Compare
Member
Author
Yeah, that's exactly what I say in this commit. However, I would prefer to not have Python2 code in the very first examples people see (for a few reasons) so I've just switched to explicitly calling |
matthewfeickert
changed the title
kratsg
approved these changes
Aug 26, 2018
Contributor
|
nice. thanks @matthewfeickert |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
4 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Resolves #214
Checklist Before Requesting Approver