Repository navigation
[Fix] function_call: stream multiple DeepSeek V3.1 tool calls correctly - #49107
Open
davrens101 wants to merge 2 commits into
Open
davrens101 wants to merge 2 commits into
davrens101 wants to merge 2 commits into
Conversation
Signed-off-by: Davis Rens <166565828+davrens101@users.noreply.github.com>
This comment has been minimized.
This comment has been minimized.
Signed-off-by: Davis Rens <166565828+davrens101@users.noreply.github.com>
This branch has not been deployed
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Fixes #42138
DeepSeekV31Detector's streaming parser used a greedy name regex and did not handle a delta that carries the end of one call plus the start of the next, so the first call's arguments were dropped and the second call's arguments were attached to the first call. Stream calls incrementally and finalize each call on its end marker.
CI States
Latest PR Test (Base): ❌ Run #42434707388
Latest PR Test (Extra): ❌ Run #42434707309
Latest PR Test (AMD ROCm 10): ❌ Run #42434707324
Tip
Base CI only covers the core cases, and its workload may not exercise your change. Use
/rerun-testto run the tests your change touches, or copy this prompt for an agent: