Visitar URL original
Integrate Impressive Changes by sibblegp · Pull Request #9 · sibblegp/coinbase_python · GitHub
Skip to content

Integrate Impressive Changes #9

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Open
sibblegp wants to merge 15 commits into
base: master
Choose a base branch
from
Open

Integrate Impressive Changes #9

Show file tree
Hide file tree
Changes from 1 commit
Commits
Show all changes
15 commits
Select commit Hold shift + click to select a range
4b38c33
Initial code and tests for Button and API support
sdobz Jan 5, 2014
b4de975
Fixed missing custom parameter in order, implemented Decimal
sdobz Jan 5, 2014
10e1695
Implemented from_cents method, fixed possible bug in transfer
sdobz Jan 5, 2014
c847601
Made order_id more consistant and made models store their original data
sdobz Jan 6, 2014
a608a14
Cleaned button, added some error handling
sdobz Jan 7, 2014
329aea9
Added more error handling via _get and _post methods, made CoinbaseEr…
sdobz Jan 7, 2014
51c3bfe
Gave CoinbaseError a more informative string representation
sdobz Jan 7, 2014
be2b6ab
Gave CoinbaseError a LESS informative string representation
sdobz Jan 7, 2014
857cf5e
Fixed bug where qty was passed as data not a parameter
sdobz Jan 8, 2014
1fcb9b5
Get rid of "Price can't be blank"
sylvainblot Feb 14, 2014
c6d8407
Merge branch 'master' of https://github.com/sibblegp/coinbase_python
sdobz Feb 14, 2014
a66da38
Merge pull request #1 from sylvainblot/master
sdobz Feb 14, 2014
f787054
price_currency_iso in button api
sylvainblot Feb 15, 2014
7b18348
Merge pull request #2 from sylvainblot/master
sdobz Feb 15, 2014
3dd2e48
Removed support for old api_key sustem, added support for new api_key…
sdobz Mar 13, 2014
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
Prev Previous commit
Next Next commit
Made order_id more consistant and made models store their original data
  • Loading branch information
@sdobz
sdobz committed Jan 6, 2014
commit c847601b59a63d318377113838fd8f4900d0ae2a
1 change: 1 addition & 0 deletions coinbase/models/button.py
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -5,6 +5,7 @@
class CoinbaseButton(object):

def __init__(self, button):
self.data = button
# Sometimes it's called code (create button) and sometimes id (sub item of create button)
# so we map them together
if 'id' in button:
Expand Down
4 changes: 3 additions & 1 deletion coinbase/models/order.py
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -7,7 +7,9 @@

class CoinbaseOrder(object):
def __init__(self, order):
self.id = order['id']
self.data = order

self.order_id = order['id']
# TODO: Account for timezone properly
#self.created_at = datetime.strptime(order['created_at'], '%Y-%m-%dT%H:%M:%S-08:00')
self.created_at = order['created_at']
Expand Down
1 change: 1 addition & 0 deletions coinbase/models/transaction.py
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -6,6 +6,7 @@
class CoinbaseTransaction(object):

def __init__(self, transaction):
self.data = transaction

self.transaction_id = transaction['id']
self.created_at = transaction.get('created_at', None)
Expand Down
2 changes: 2 additions & 0 deletions coinbase/models/transfer.py
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -5,6 +5,8 @@
class CoinbaseTransfer(object):

def __init__(self, transfer):
self.data = transfer

self.type = transfer['type']
self.code = transfer['code']
self.created_at = transfer['created_at']
Expand Down
6 changes: 3 additions & 3 deletions coinbase/tests.py
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -224,7 +224,7 @@ def test_creating_order(self):

order = self.account.create_order("93865b9cae83706ae59220c013bc0afd")

this(order.id).should.equal("7RTTRDVP")
this(order.order_id).should.equal("7RTTRDVP")
this(order.total_btc).should.equal(CoinbaseAmount(1, 'BTC'))

this(order.button.button_id).should.equal("93865b9cae83706ae59220c013bc0afd")
Expand All @@ -239,7 +239,7 @@ def test_order_list(self):

orders = self.account.orders()
this(orders).should.be.an(list)
this(orders[0].id).should.equal("A7C52JQT")
this(orders[0].order_id).should.equal("A7C52JQT")

@httprettified
def test_getting_order(self):
Expand All @@ -250,7 +250,7 @@ def test_getting_order(self):

order = self.account.get_order("A7C52JQT")

this(order.id).should.equal("A7C52JQT")
this(order.order_id).should.equal("A7C52JQT")
this(order.status).should.equal("completed")
this(order.total_btc).should.equal(CoinbaseAmount(Decimal(".1"), "BTC"))
this(order.button.name).should.equal("test")
Expand Down