Visitar URL original
improvement(docs): simplify workflow lightbox and retire migration artifacts by waleedlatif1 · Pull Request #9496 · simstudioai/sim · GitHub
Skip to content

improvement(docs): simplify workflow lightbox and retire migration artifacts - #9496

Merged
waleedlatif1 merged 4 commits into
stagingfrom
codex/docs-workflow-lightbox
Oct 31, 2026
Merged

improvement(docs): simplify workflow lightbox and retire migration artifacts#9496
waleedlatif1 merged 4 commits into
stagingfrom
codex/docs-workflow-lightbox

Conversation

@waleedlatif1

@waleedlatif1 waleedlatif1 commented Oct 31, 2026 •
edited
Loading

Copy link
Copy Markdown
Collaborator

Summary

  • Simplify the expanded workflow to a live canvas with pan, zoom, and movable blocks; remove the configuration inspector.
  • Share image and workflow lightbox geometry, dismissal, and focus behavior.
  • Retire historical migration reports and captures, preserving compatibility fixtures, CI checks, authoring guidance, and pending publication requirements.

Type of Change

  • Improvement

Testing

  • Parallel cleanup and interaction audits; pinned Biome 2.0.6 and diff checks passed.
  • Verified relocated compatibility baseline is byte-identical.
  • Extended browser E2E for workflow rendering and lightbox lifecycle. Full builds and browser checks run in CI; deployed QA pending.

Checklist

  • Code follows project style guidelines
  • Self-reviewed my changes
  • Tests added/updated and passing (new tests pass the test-audit authoring gate)
  • No new warnings introduced
  • I confirm that I have read and agree to the terms outlined in the Contributor License Agreement (CLA)

@waleedlatif1
waleedlatif1 requested a review from a team as a code owner October 31, 2026 03:58
@vercel

vercel Bot commented Oct 31, 2026 •
edited
Loading

Copy link
Copy Markdown

The latest updates on your projects. Learn more about Vercel for GitHub.

Project Deployment Actions Updated
docs Ready Ready Preview Oct 31, 2026 4:32am UTC

Request Review

@waleedlatif1

waleedlatif1 commented Oct 31, 2026

Copy link
Copy Markdown
Collaborator Author

@greptile

@waleedlatif1

waleedlatif1 commented Oct 31, 2026

Copy link
Copy Markdown
Collaborator Author

@cubic-dev-ai review this PR

@cubic-dev-ai

cubic-dev-ai Bot commented Oct 31, 2026

Copy link
Copy Markdown
Contributor

@cubic-dev-ai review this PR

@waleedlatif1 I have started the AI code review. It will take a few minutes to complete.

cubic-dev-ai[bot]
cubic-dev-ai Bot reviewed Oct 31, 2026
View reviewed changes

@cubic-dev-ai cubic-dev-ai Bot left a comment •
edited
Loading

Copy link
Copy Markdown
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

All reported issues were addressed across 95 files

Reply with feedback, questions, or to request a fix.

Turn on auto-fix | Re-trigger cubic

Comment thread apps/docs/components/workflow-preview/workflow-data.ts Resolved
@greptile-apps

greptile-apps Bot commented Oct 31, 2026 •
edited
Loading

Copy link
Copy Markdown
Contributor

RetriggerView in GreptileConfidence Score: 5/5

[Medium impact] The PR appears safe to merge; no new blocking issue was found.

Summary

The PR simplifies workflow expansion and retires historical migration artifacts.

  • Expanded workflow previews open as interactive canvases without a configuration inspector.
  • Image and workflow viewers use the same lightbox frame.
  • Historical migration reports and captures are removed while compatibility checks keep a frozen content inventory.

No new actionable issues were found. The earlier unnumbered clipping concern is addressed: the configuration inspector and its expandable fields are gone.

Reviews (4) · Last reviewed commit: "chore(docs): drop retired export from un..." · Reviewed by Greptile

greptile-apps[bot]
greptile-apps Bot reviewed Oct 31, 2026
View reviewed changes
Comment thread apps/docs/scripts/test-navigation-e2e.ts Resolved
@waleedlatif1

waleedlatif1 commented Oct 31, 2026

Copy link
Copy Markdown
Collaborator Author

@greptile

@waleedlatif1

waleedlatif1 commented Oct 31, 2026

Copy link
Copy Markdown
Collaborator Author

@cubic-dev-ai review this PR

@cubic-dev-ai

cubic-dev-ai Bot commented Oct 31, 2026

Copy link
Copy Markdown
Contributor

@cubic-dev-ai review this PR

@waleedlatif1 I have started the AI code review. It will take a few minutes to complete.

@waleedlatif1 waleedlatif1 changed the title improvement(docs): inspect workflows on canvas and retire migration artifacts improvement(docs): simplify workflow lightbox and retire migration artifacts Oct 31, 2026
cubic-dev-ai[bot]
cubic-dev-ai Bot reviewed Oct 31, 2026
View reviewed changes

@cubic-dev-ai cubic-dev-ai Bot left a comment

Copy link
Copy Markdown
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

No issues found across 94 files

Confidence score: 5/5

  • Automated review surfaced no issues in the provided summaries.
  • No files require special attention.

Turn on auto-fix | Re-trigger cubic

@waleedlatif1

waleedlatif1 commented Oct 31, 2026

Copy link
Copy Markdown
Collaborator Author

@greptile

@waleedlatif1

waleedlatif1 commented Oct 31, 2026

Copy link
Copy Markdown
Collaborator Author

@cubic-dev-ai review this PR

@cubic-dev-ai

cubic-dev-ai Bot commented Oct 31, 2026

Copy link
Copy Markdown
Contributor

@cubic-dev-ai review this PR

@waleedlatif1 I have started the AI code review. It will take a few minutes to complete.

@waleedlatif1

waleedlatif1 commented Oct 31, 2026

Copy link
Copy Markdown
Collaborator Author

@greptile

@waleedlatif1

waleedlatif1 commented Oct 31, 2026

Copy link
Copy Markdown
Collaborator Author

@cubic-dev-ai review this PR

@cubic-dev-ai

cubic-dev-ai Bot commented Oct 31, 2026

Copy link
Copy Markdown
Contributor

@cubic-dev-ai review this PR

@waleedlatif1 I have started the AI code review. It will take a few minutes to complete.

cubic-dev-ai[bot]
cubic-dev-ai Bot reviewed Oct 31, 2026
View reviewed changes

@cubic-dev-ai cubic-dev-ai Bot left a comment

Copy link
Copy Markdown
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

No issues found across 96 files

Confidence score: 5/5

  • Automated review surfaced no issues in the provided summaries.
  • No files require special attention.

Turn on auto-fix | Re-trigger cubic

@waleedlatif1
waleedlatif1 merged commit 26ba3a9 into staging Oct 31, 2026
133 of 135 checks passed
@waleedlatif1 waleedlatif1 mentioned this pull request Oct 31, 2026
Merged
@waleedlatif1
waleedlatif1 deleted the codex/docs-workflow-lightbox branch October 31, 2026 06:11

This branch was successfully deployed

1 active deployment
Preview — 924d9971 Deployed Oct 31, 2026 by vercel[bot]
View deployment
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

@greptile-apps greptile-apps[bot] greptile-apps[bot] left review comments
@cubic-dev-ai cubic-dev-ai[bot] cubic-dev-ai[bot] left review comments

Assignees

No one assigned

Labels

None yet

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

1 participant

@waleedlatif1