feat(desktop): build a Windows File/Edit/View/Help menu

The macOS app-menu shape (hide/hideOthers/unhide, a windowMenu whose Close item takes Ctrl+W off macOS) is wrong on Windows. Build a Windows template with the same items and accelerators, Exit via role quit, and hidden Alt+Left/Alt+Right for history. The macOS template is unchanged.
waleedlatif1 · Oct 31, 2026 · Oct 31, 2026 · Oct 31, 2026 · Oct 31, 2026 · Oct 31, 2026
commit b8dfb41aeff2c1c6795f0facc891629ef5e9443f
diff --git a/apps/desktop/src/main/menu.test.ts b/apps/desktop/src/main/menu.test.ts
@@ -6,7 +6,7 @@ import type { MenuItemConstructorOptions } from 'electron'
 import type { ConfigStore } from '@/main/config'
 import { buildMenuTemplate, type MenuDeps } from '@/main/menu'
 
-function makeDeps(origin = 'https://sim.ai'): MenuDeps {
+function makeDeps(platform: NodeJS.Platform = 'darwin', origin = 'https://sim.ai'): MenuDeps {
   return {
     config: {
       filePath: '/tmp/settings.json',
@@ -29,20 +29,59 @@ function makeDeps(origin = 'https://sim.ai'): MenuDeps {
     signOut: vi.fn(),
     checkForUpdates: vi.fn(),
     openDiagnostics: vi.fn(),
+    platform,
   }
 }
 
-function submenu(
-  template: MenuItemConstructorOptions[],
-  label: string
-): MenuItemConstructorOptions[] {
-  return (template.find((item) => item.label === label || item.role === label.toLowerCase())
-    ?.submenu ?? []) as MenuItemConstructorOptions[]
+/** Every item at any depth, so hidden resource items count too. */
+function flatten(items: MenuItemConstructorOptions[]): MenuItemConstructorOptions[] {
+  return items.flatMap((item) => [
+    item,
+    ...(Array.isArray(item.submenu) ? flatten(item.submenu as MenuItemConstructorOptions[]) : []),
+  ])
+}
+
+function accelerators(template: MenuItemConstructorOptions[]): Set<string> {
+  return new Set(
+    flatten(template).flatMap((item) =>
+      typeof item.accelerator === 'string' ? [item.accelerator] : []
+    )
+  )
 }
 
 describe('buildMenuTemplate', () => {
-  it('never exposes developer tools in the application menu', () => {
-    const view = submenu(buildMenuTemplate(makeDeps()), 'View')
-    expect(view.some((item) => item.role === 'toggleDevTools')).toBe(false)
+  it.each(['darwin', 'win32'] as const)('never exposes developer tools on %s', (platform) => {
+    const items = flatten(buildMenuTemplate(makeDeps(platform)))
+    expect(items.some((item) => item.role === 'toggleDevTools')).toBe(false)
+  })
+
+  it('keeps every macOS shortcut working on Windows', () => {
+    const windows = accelerators(buildMenuTemplate(makeDeps('win32')))
+    for (const accelerator of accelerators(buildMenuTemplate(makeDeps('darwin')))) {
+      expect(windows).toContain(accelerator)
+    }
+    expect(windows).toContain('Alt+Left')
+    expect(windows).toContain('Alt+Right')
+  })
+
+  it('builds the Windows menu without macOS-only app roles', () => {
+    // windowMenu is excluded too: off macOS it adds a Close item on Ctrl+W
+    // that would steal the hidden Close Tab accelerator.
+    const roles = flatten(buildMenuTemplate(makeDeps('win32'))).map((item) => item.role)
+    for (const role of ['hide', 'hideOthers', 'unhide', 'services', 'windowMenu', 'appMenu']) {
+      expect(roles).not.toContain(role)
+    }
+    expect(roles).toContain('editMenu')
+    expect(roles).toContain('quit')
+  })
+
+  it('binds each Windows accelerator to exactly one item', () => {
+    const counts = new Map<string, number>()
+    for (const item of flatten(buildMenuTemplate(makeDeps('win32')))) {
+      if (typeof item.accelerator === 'string') {
+        counts.set(item.accelerator, (counts.get(item.accelerator) ?? 0) + 1)
+      }
+    }
+    expect([...counts].filter(([, count]) => count > 1)).toEqual([])
   })
 })