Visitar URL original
v0.9.38: favicon service, docs improvements by waleedlatif1 · Pull Request #9500 · simstudioai/sim · GitHub
Skip to content

v0.9.38: favicon service, docs improvements #9500

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
waleedlatif1 merged 6 commits into from
Oct 31, 2026
Merged

v0.9.38: favicon service, docs improvements #9500

Changes from 1 commit
Commits
Show all changes
6 commits
Select commit Hold shift + click to select a range
17389db
feat(favicons): one server route for every site icon, with parent-dom…
waleedlatif1 Oct 31, 2026
e56bf3d
fix(knowledge): keep a bundle's document token totals on import (#9495)
waleedlatif1 Oct 31, 2026
26ba3a9
improvement(docs): simplify workflow lightbox and retire migration ar…
waleedlatif1 Oct 31, 2026
79a7aa1
improvement(favicons): resolve platform tenants no provider can see, …
waleedlatif1 Oct 31, 2026
a5fba63
fix(favicons): let a mounted icon retry once its failure ages out (#9…
waleedlatif1 Oct 31, 2026
b3f9298
fix(docs): restore container expansion and verify canvas interactions…
waleedlatif1 Oct 31, 2026
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
Prev Previous commit
Next Next commit
fix(favicons): let a mounted icon retry once its failure ages out (#9501 
)

A failed load set per-instance state that pinned the icon to its fallback until it
unmounted, so the five-minute miss window never reached an icon already on screen. The
module-level miss cache is now the only failure record; a reducer only re-renders on
error, so the next render after the entry expires asks again (a confirmed miss is still
answered from the HTTP cache).
  • Loading branch information
@waleedlatif1
waleedlatif1 authored Oct 31, 2026
commit a5fba63a558c41995280da50ebeac654b65fa4de
15 changes: 8 additions & 7 deletions apps/sim/components/favicon.tsx
View file
Open in desktop
Original file line number Diff line number Diff line change
@@ -1,14 +1,15 @@
'use client'

import { type ReactNode, useState } from 'react'
import { type ReactNode, useReducer } from 'react'
import { cn } from '@sim/emcn'
import { LRUCache } from 'lru-cache'
import { faviconSrc } from '@/lib/favicon/url'

/**
* Hosts whose icon just failed, so an icon that mounts again renders its fallback at once
* instead of an empty slot first. An `<img>` can't tell no icon from a provider outage, so this
* lasts only as long as the route retries an outage; a confirmed miss stays in the HTTP cache.
* Hosts whose icon failed recently: the only failure record, so mounted and remounted icons
* render the fallback at once instead of an empty slot. An `<img>` can't tell no icon from a
* provider outage, so an entry lasts only as long as the route retries an outage; the next render
* after that asks again, and a confirmed miss stays in the HTTP cache.
*/
const knownMisses = new LRUCache<string, true>({ max: 500, ttl: 5 * 60 * 1000 })

Expand All @@ -27,8 +28,8 @@ interface FaviconProps {
* of a provider's placeholder.
*/
export function Favicon({ host, fallback, className }: FaviconProps) {
const [failedHost, setFailedHost] = useState<string | null>(null)
if (!host || failedHost === host || knownMisses.has(host)) return fallback
const [, rerender] = useReducer((failures: number) => failures + 1, 0)
if (!host || knownMisses.has(host)) return fallback
return (
<img
src={faviconSrc(host)}
Expand All @@ -38,7 +39,7 @@ export function Favicon({ host, fallback, className }: FaviconProps) {
className={cn('rounded-sm', className)}
onError={() => {
knownMisses.set(host, true)
setFailedHost(host)
rerender()
}}
/>
)
Expand Down
Loading