Visitar URL original
Fix redirect for Spring HATEOAS by Buzzardo · Pull Request #30107 · spring-projects/spring-boot · GitHub
Skip to content

Fix redirect for Spring HATEOAS - #30107

Closed
Buzzardo wants to merge 1 commit into
spring-projects:mainfrom
Buzzardo:issue-30106
Closed

Buzzardo wants to merge 1 commit into
spring-projects:mainfrom
Buzzardo:issue-30106

Conversation

@Buzzardo

@Buzzardo Buzzardo commented Mar 8, 2022

Copy link
Copy Markdown

Change the redirect location to point to the Spring HATEOAS part
of the documentation.

Change the redirect location to point to the Spring HATEOAS part
 of the documentation.
@spring-projects-issues spring-projects-issues added the status: waiting-for-triage An issue that has not yet been triaged. Contributions will not be accepted. label Mar 8, 2022
@scottfrederick scottfrederick changed the title issue-30106 fix Fix redirect for Spring HATEOAS Mar 8, 2022
@scottfrederick scottfrederick added type: documentation A documentation update and removed status: waiting-for-triage An issue that has not yet been triaged. Contributions will not be accepted. labels Mar 8, 2022
@scottfrederick scottfrederick added this to the 2.6.x milestone Mar 8, 2022
@snicoll snicoll self-assigned this Mar 9, 2022
@snicoll snicoll modified the milestones: 2.6.x, 2.6.5 Mar 9, 2022
@snicoll

snicoll commented Mar 9, 2022

Copy link
Copy Markdown
Member

Thanks for the PR @Buzzardo but there is no such anchor.

@snicoll snicoll closed this Mar 9, 2022
@snicoll snicoll added the status: declined A suggestion or change that we don't feel we should currently apply label Mar 9, 2022
@snicoll snicoll removed their assignment Mar 9, 2022
@snicoll snicoll removed this from the 2.6.5 milestone Mar 9, 2022
@Buzzardo

Buzzardo commented Mar 9, 2022

Copy link
Copy Markdown
Author

The current value also does not exist anywhere in the docs. It seems that the point of this value is to get the Initializr to the right place in the docs. Given that https://docs.spring.io/spring-boot/docs/current/reference/htmlsingle/#web.spring-hateoas is a valid target and that https://docs.spring.io/spring-boot/docs/current/reference/htmlsingle/#spring-mvc.spring-hateoas is not a valid target, I figured my change would fix the issue. NOTE: spring-mvc.spring-hateoas is not in the doc files, but web.spring-hateoas is in the doc files.

While I'm here, what is the point of these values? None of them exist in the document, so there is other processing going on, but there is no indication of what that other processing is.

@snicoll

snicoll commented Mar 9, 2022

Copy link
Copy Markdown
Member

It rewrites old anchors to the new one, see be85f31

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

status: declined A suggestion or change that we don't feel we should currently apply type: documentation A documentation update

Projects

None yet

Development

Successfully merging this pull request may close these issues.

4 participants