Repository navigation
Guard BtShared.nRef reads with SQLITE_OMIT_SHARED_CACHE - #628
Open
LucaCappelletti94 wants to merge 1 commit into
Open
LucaCappelletti94 wants to merge 1 commit into
LucaCappelletti94 wants to merge 1 commit into
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
SQLCipher 5.0.0-beta.1 no longer compiles with
SQLITE_OMIT_SHARED_CACHE. The shared-cache fix in 1825a0a readsBtShared.nRefin thecipher_migraterefusal and in anassertinsqlcipher_ctx_set_error, and SQLite declaresnRefonly when shared cache is compiled in. Builds that omit shared cache, such as thesqlite-wasm-rsWasm build, stop with'BtShared' has no member named 'nRef'.Both reads now sit under
#ifndef SQLITE_OMIT_SHARED_CACHE, the same guard SQLite puts around the field. Without shared cacheBtree.sharableis never set, soctx->sharedstays 0 and neither check could fire. Builds with shared cache compile exactly the code they did before.The shared-cache tests in the core, compatibility and rekey suites are skipped with
ifcapable shared_cachewhen shared cache is omitted, since acache=sharedURI then opens a private cache and those tests cannot hold. That lets the SQLCipher suite run on a build without shared cache.