Visitar URL original
toString does not match V8 stack trace format · Issue #22 · stacktracejs/stackframe · GitHub
Skip to content

toString does not match V8 stack trace format #22

Closed
Closed
toString does not match V8 stack trace format#22
Labels
a:feature

Description

@niftylettuce
niftylettuce
opened on Sep 13, 2019

Could we modify toString so that it closely matches https://v8.dev/docs/stack-trace-api#appendix%3A-stack-trace-format instead of current format?

Calling Error.prepareStackTrace(err, stackframes) does not give proper output.

Activity

  1. niftylettuce commented on Sep 13, 2019

    @niftylettuce
    niftylettuce
    on Sep 13, 2019
    ContributorAuthor

    Here is how Node prepares it:

    https://github.com/nodejs/node/blob/b6bfc193788b1838bee73d584fe089e1104b9f88/src/node_errors.cc#L142-L175

  2. eriwen commented on Sep 14, 2019

    @eriwen
    eriwen
    on Sep 14, 2019
    Member

    This is fixed by #23. Thanks @niftylettuce!

  3. eriwen
    closed this as completedon Sep 14, 2019
  4. eriwen
    added
    a:feature
    on Sep 14, 2019
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Metadata

Metadata

Assignees

No one assigned

    Labels

    a:feature

    Type

    No type

    Projects

    No projects

      Milestone

      No milestone

      Relationships

      None yet

      Development

      No branches or pull requests

      Issue actions