Visitar URL original
Fix: remove the default "false" value for ENABLE_EMBEDDED_WALLETS by JiahuiWho · Pull Request #1049 · stellar/stellar-disbursement-platform-backend · GitHub
Skip to content

Fix: remove the default "false" value for ENABLE_EMBEDDED_WALLETS - #1049

Merged
JiahuiWho merged 1 commit into
developfrom
fix-integration-tests-env-var
Feb 10, 2026
Merged

Fix: remove the default "false" value for ENABLE_EMBEDDED_WALLETS#1049
JiahuiWho merged 1 commit into
developfrom
fix-integration-tests-env-var

Conversation

@JiahuiWho

@JiahuiWho JiahuiWho commented Feb 9, 2026 •
edited
Loading

Copy link
Copy Markdown
Contributor

What

  1. matrix.ENABLE_EMBEDDED_WALLETS default value "false" is a non-empty string, prevents docker compose defaults to kicks in
  2. updaterun_embedded_wallet_test.sh and changelog

Why

Integration tests failed due to "embedded wallets feature is disabled"
https://github.com/stellar/stellar-disbursement-platform-backend/actions/runs/21842255128/job/63036397368

Known limitations

N/A

Checklist

  • Title follows SDP-1234: Add new feature or Chore: Refactor package xyz format. The Jira ticket code was included if available.
  • PR has a focused scope and doesn't mix features with refactoring
  • Tests are included (if applicable)
  • CHANGELOG.md is updated (if applicable)
  • If contracts changed, run the Contract WASM Artifacts workflow and open a PR to update the WASMs on dev
  • CONFIG/SECRETS changes are updated in helmcharts and deployments (if applicable)
  • Preview deployment works as expected
  • Ready for production

@JiahuiWho
JiahuiWho temporarily deployed to Internal SEP Tests February 9, 2026 23:57 — with GitHub Actions Inactive
@JiahuiWho
JiahuiWho temporarily deployed to Receiver Registration - E2E Integration Tests (Stellar) February 9, 2026 23:57 — with GitHub Actions Inactive
@JiahuiWho
JiahuiWho marked this pull request as ready for review February 9, 2026 23:58
Copilot AI review requested due to automatic review settings February 9, 2026 23:58
@stellar-jenkins

stellar-jenkins commented Feb 10, 2026

Copy link
Copy Markdown

stellar-disbursement-platform-backend-preview is available here:
SDP: https://sdp-backend-pr1049.previews.kube001.services.stellar-ops.com/health
AP: https://sdp-ap-pr1049.previews.kube001.services.stellar-ops.com/health
Frontend: https://sdp-backend-dashboard-pr1049.previews.kube001.services.stellar-ops.com

Copilot AI reviewed Feb 10, 2026
View reviewed changes

Copilot AI left a comment

Copy link
Copy Markdown
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Pull request overview

This PR addresses failing embedded-wallet integration tests by adjusting how ENABLE_EMBEDDED_WALLETS is provided in the GitHub Actions matrix so Docker Compose defaults can take effect, and by adding defaults to the local embedded-wallet test runner script.

Changes:

  • Remove the GitHub Actions default of 'false' for ENABLE_EMBEDDED_WALLETS so Docker Compose variable expansion can apply defaults.
  • Add default values for RPC_URL and EMBEDDED_WALLETS_WASM_HASH in run_embedded_wallet_test.sh.
  • Add an Unreleased entry in CHANGELOG.md.

Reviewed changes

Copilot reviewed 3 out of 3 changed files in this pull request and generated 3 comments.

File Description
internal/integrationtests/run_embedded_wallet_test.sh Adds defaults for embedded-wallet RPC + WASM hash when running locally.
CHANGELOG.md Adds an Unreleased changelog entry related to integration tests.
.github/workflows/e2e_integration_test.yml Adjusts how ENABLE_EMBEDDED_WALLETS is populated from the matrix to avoid forcing 'false'.

Comment thread .github/workflows/e2e_integration_test.yml Resolved
Comment thread CHANGELOG.md Resolved
Comment thread internal/integrationtests/run_embedded_wallet_test.sh Resolved
@JiahuiWho
JiahuiWho merged commit 22bf6ff into develop Feb 10, 2026
24 checks passed
@JiahuiWho
JiahuiWho deleted the fix-integration-tests-env-var branch February 10, 2026 13:43
hypekostas pushed a commit that referenced this pull request Aug 4, 2026
@dependabot
Chore(deps): Bump docker/login-action from 4.4.0 to 4.5.1 in the all-…
646e6cf 
…actions group (#1174)

Bumps the all-actions group with 1 update: [docker/login-action](https://github.com/docker/login-action).

Updates `docker/login-action` from **4.4.0** to **4.5.1**

Release notes (sourced from [docker/login-action releases](https://github.com/docker/login-action/releases)):

## v4.5.1

- Support `dhi.io` as Docker Hub OIDC registry by `@crazy-max` in [docker/login-action#1054](docker/login-action#1054)

**Full Changelog:**  
docker/login-action@v4.5.0...v4.5.1

## v4.5.0

- Docker Hub OIDC login support by `@crazy-max` in [docker/login-action#1048](docker/login-action#1048)
- Bump `@aws-sdk/client-ecr` and `@aws-sdk/client-ecr-public` to **3.1091.0** in [docker/login-action#1037](docker/login-action#1037)
- Bump `@docker/actions-toolkit` from **0.92.0** to **0.94.0** in:
  - [docker/login-action#1044](docker/login-action#1044)
  - [docker/login-action#1050](docker/login-action#1050)
- Bump `brace-expansion` from **1.1.13** to **1.1.16** in [docker/login-action#1046](docker/login-action#1046)
- Bump `js-yaml` from **5.2.0** to **5.2.1** in [docker/login-action#1038](docker/login-action#1038)

**Full Changelog:**  
docker/login-action@v4.4.0...v4.5.0

## Commits

- `abd2ef4` – Merge pull request #1055 from `crazy-max/test-registry-auth-oidc`
- `d49d3a9` – Merge pull request #1054 from `crazy-max/oidc-missing-dhi`
- `b58b17c` – test: cover Docker Hub OIDC with registry-auth
- `be646c2` – chore: update generated content
- `d77c059` – support `dhi.io` as Docker Hub OIDC registry
- `06fb636` – Merge pull request #1037 from `docker/dependabot/npm_and_yarn/aws-sdk-dependencies`
- `a8bc953` – [dependabot skip] chore: update generated content
- `f54b901` – build(deps): bump the aws-sdk-dependencies group across 1 directory with 2 updates
- `77f18f6` – Merge pull request #1049 from `docker/dependabot/github_actions/codeql-actions`
- `ec0bf28` – Merge pull request #1050 from `docker/dependabot/npm_and_yarn/docker/actions-toolkit`
- Additional commits are available in the compare view:  
  docker/login-action@v4.4.0...v4.5.1

This branch was previously deployed

2 inactive deployments
Internal SEP Tests — 359d5df5 Deployed Feb 9, 2026 by JiahuiWho via internal-sep-validation #435
Receiver Registration - E2E Integration Tests (Stellar) — 359d5df5 Deployed Feb 9, 2026 by JiahuiWho via db-migration #2837
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

Copilot code review Copilot
Copilot review effort
Applies to this pull request for everyone.Learn more about Copilot code review.
Copilot left review comments
@marwen-abid marwen-abid marwen-abid approved these changes

Assignees

@JiahuiWho JiahuiWho

Labels

None yet

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

4 participants

@JiahuiWho @stellar-jenkins @marwen-abid