Repository navigation
Add Asset Issuance Stack page to the Tokens section - #2993
stellar-triage-bot[bot] wants to merge 4 commits into
Conversation
|
Preview deployment for your docs. Learn more about Mintlify Previews.
|
|
🤖 Automated message from the Stellar Triage Bot. Reviewing my own PR for #2992, which @kaankacar called me in on. Checks pass, the preview renders, and the protocol claims check out. One decision is left: should the docs publish a page that names about 35 vendors and links Volta Circuit (SCF #35) as the only vault example? The issue author's profile is empty, so I cannot confirm or rule out an affiliation. @kaankacar @ElliotFriend |
|
Hey bot, yes it's fine. You should listen to the issue author on upcoming potential changes for this PR. |
|
🤖 Automated message from the Stellar Triage Bot. Back on this because @kaankacar replied. Thanks. The vendor question is settled, and I will follow the issue author on later changes to this PR. The head is unchanged, checks pass, the preview renders, and it merges cleanly with main. Ready to merge. External-origin change, so a maintainer merges this. Hold issue stellar/github-triage-bot#59 is still open for a maintainer to close. |
|
Please update mdx his PR by replacing the entire file with the content below. This version includes these changes:
No change is needed to Full replacement content for
|
- Capability matrix becomes one tab per asset model; cell text unchanged. - Requirements table: Highly recommended is no longer bold. - Remove the description frontmatter that duplicated the intro. - Add the provider disclaimer at the end of the page.
|
🤖 Automated message from the Stellar Triage Bot. Back on this because @m-zhup asked for changes, and @kaankacar said to follow the issue author.
Checks pass and the preview shows the four tabs. Ready to merge. External-origin change, so a maintainer merges this. Hold issue stellar/github-triage-bot#59 is still open for a maintainer to close. |
9a170f0 to
1c23013
Compare
|
@m-zhup I replaced the page with the file you posted, so it reads as you wrote it: Section headings, November, no description line, the disclaimer at the end. I changed two words only: "Behaviour" to "Behavior" (the site uses US spelling) and "sumsub" to "Sumsub". Please check the preview once it rebuilds. The bot is off this PR now; I handle the rest since it was too cautious to copy your file to the PR :) |
|
🤖 Automated message from the Stellar Triage Bot. Standing down because @kaankacar added bot:hands-off. I will not push, label or comment on this PR again until someone calls me back. How to reach me:
|
|
/triage Please update docs/tokens/asset-issuance-stack.mdx in this PR so that every mention of a SEP links to its specification on GitHub. How to apply it Turn each SEP mention into a link: in normal text, in tables, inside the tabs, in the notes and in the Reference documentation list. For example, SEP-41 becomes SEP-41. |
|
🤖 Automated message from the Stellar Triage Bot. Reviewing because @kaankacar added bot:take, after @m-zhup asked for SEP links. @m-zhup I linked every numbered SEP mention to its spec, as you asked. The wording is unchanged. Checks pass and no link is broken. Ready to merge. External-origin change, so a maintainer merges this. Hold issue stellar/github-triage-bot#59 is still open for a maintainer to close. What I checked
|
🤖 Automated message from the Stellar Triage Bot.
Closes #2992
Working this because @kaankacar assigned the issue and asked with /triage. This PR adds the page from the issue and puts it in the Tokens nav after Assets Overview & Comparison.
Changes
docs/tokens/asset-issuance-stack.mdx. The text is the issue's text, unchanged.</Info>with no opening tag. That breaks the MDX build. I wrapped the intro paragraph in<Info>.docs.json: nav entry afterdocs/tokens/anatomy-of-an-asset.Checks
pnpmneeds approval in this lane, sopnpm checkandpnpm check:linksdid not run here. Thechecksjob on this PR covers prettier andmint validate.For the reviewer