Visitar URL original
Little mistake in last-modified changes by jeroenj · Pull Request #232 · stringer-rss/stringer · GitHub
Skip to content

Little mistake in last-modified changes #232

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
swanson merged 1 commit into from
Jul 17, 2013
Merged

Little mistake in last-modified changes #232

Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
Revert "Obviously we should update last_fetched when nothing has chan… 
…ged"

This reverts commit 25a6030.

Actually we do not want this. We should only update that timestamp to what we get back from the feed.
  • Loading branch information
@jeroenj
jeroenj committed Jul 17, 2013
commit c0caec3c0b7e857f1a122172e0d789587c16cabb
6 changes: 3 additions & 3 deletions app/tasks/fetch_feed.rb
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -21,10 +21,10 @@ def fetch
new_entries_from(raw_feed).each do |entry|
StoryRepository.add(entry, @feed)
end
end

FeedRepository.update_last_fetched(@feed, raw_feed.last_modified)
FeedRepository.set_status(:green, @feed)
FeedRepository.update_last_fetched(@feed, raw_feed.last_modified)
FeedRepository.set_status(:green, @feed)
end
rescue Exception => ex
FeedRepository.set_status(:red, @feed)

Expand Down