Visitar URL original
Replace deprecated inlineDynamicImports with codeSplitting by remiposo · Pull Request #736 · tailor-platform/sdk · GitHub
Skip to content

Replace deprecated inlineDynamicImports with codeSplitting - #736

Merged
remiposo merged 2 commits into
mainfrom
fix/replace-deprecated-inlineDynamicImports
Mar 12, 2026
Merged

Replace deprecated inlineDynamicImports with codeSplitting#736
remiposo merged 2 commits into
mainfrom
fix/replace-deprecated-inlineDynamicImports

Conversation

@remiposo

@remiposo remiposo commented Mar 12, 2026 •
edited
Loading

Copy link
Copy Markdown
Contributor

Summary

  • Replace deprecated output.inlineDynamicImports: true with output.codeSplitting: false across all bundlers
  • Deprecated in rolldown rc.1 (#7870)

Running apply emitted the following deprecation warning:

WARN  inlineDynamicImports option is deprecated, please use codeSplitting: false instead.

🤖 Generated with Claude Code

@remiposo @claude
Replace deprecated inlineDynamicImports with codeSplitting
2554cbf 
inlineDynamicImports was deprecated in rolldown rc.1 (#7870).
The equivalent replacement is codeSplitting: false.

Co-Authored-By: Claude Opus 4.6 <noreply@anthropic.com>
@remiposo
remiposo requested a review from toiroakr as a code owner March 12, 2026 02:55
@changeset-bot

changeset-bot Bot commented Mar 12, 2026 •
edited
Loading

Copy link
Copy Markdown

🦋 Changeset detected

Latest commit: db7399c

The changes in this PR will be included in the next version bump.

This PR includes changesets to release 2 packages
Name Type
@tailor-platform/sdk Patch
@tailor-platform/create-sdk Patch

Not sure what this means? Click here to learn what changesets are.

Click here if you're a maintainer who wants to add another changeset to this PR

@pkg-pr-new

pkg-pr-new Bot commented Mar 12, 2026 •
edited
Loading

Copy link
Copy Markdown

Open in StackBlitz

npm i https://pkg.pr.new/@tailor-platform/create-sdk@736

commit: 7b4db28

@remiposo
remiposo marked this pull request as draft March 12, 2026 02:57
devin-ai-integration[bot]
devin-ai-integration Bot reviewed Mar 12, 2026
View reviewed changes

@devin-ai-integration devin-ai-integration Bot left a comment

Copy link
Copy Markdown
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

✅ Devin Review: No Issues Found

Devin Review analyzed this PR and found no potential bugs to report.

View in Devin Review to see 2 additional findings.

Open in Devin Review

@github-actions

This comment has been minimized.

Sign in to view
@remiposo @claude
Add changeset for inlineDynamicImports deprecation fix
db7399c 
Co-Authored-By: Claude Opus 4.6 <noreply@anthropic.com>
@claude

claude Bot commented Mar 12, 2026 •
edited
Loading

Copy link
Copy Markdown

📖 Docs Consistency Check

✅ No inconsistencies found between documentation and implementation.

Checked areas:

  • CLI reference (packages/sdk/docs/cli-reference.md and packages/sdk/docs/cli/*.md) - No changes to CLI commands or options
  • Service documentation (packages/sdk/docs/services/*.md) - No changes to public APIs
  • Configuration reference (packages/sdk/docs/configuration.md) - No changes to config schema
  • Code patterns and examples (example/, CLAUDE.md) - No changes to user-facing patterns
  • Internal bundler configuration - Confirmed no documentation references bundler implementation details

Analysis:
This PR replaces deprecated rolldown option inlineDynamicImports: true with codeSplitting: false across internal bundler files. This is purely an internal implementation change that:

  • Does not affect CLI interface
  • Does not affect public API surface
  • Does not affect configuration schema
  • Does not affect code patterns users write
  • Is transparent to end users (bundler behavior remains the same)

Since this is an internal bundler configuration detail, no documentation updates are required.

@github-actions

github-actions Bot commented Mar 12, 2026

Copy link
Copy Markdown
Contributor

Code Metrics Report (packages/sdk)

main (7d7acd2) #736 (7b4db28) +/-
Coverage 55.3% 55.3% 0.0%
Code to Test Ratio 1:0.3 1:0.3 0.0
Details 
  |                    | main (7d7acd2) | #736 (7b4db28) | +/-  |
  |--------------------|----------------|----------------|------|
  | Coverage           |          55.3% |          55.3% | 0.0% |
  |   Files            |            298 |            298 |    0 |
  |   Lines            |          10019 |          10019 |    0 |
  |   Covered          |           5546 |           5546 |    0 |
  | Code to Test Ratio |          1:0.3 |          1:0.3 |  0.0 |
  |   Code             |          58419 |          58419 |    0 |
  |   Test             |          23258 |          23258 |    0 |

Code coverage of files in pull request scope (86.9% → 86.9%)

Files Coverage +/- Status
packages/sdk/src/cli/bundler/query/query-bundler.ts 92.3% 0.0% modified
packages/sdk/src/cli/commands/function/bundle.ts 96.5% 0.0% modified
packages/sdk/src/cli/commands/generate/seed/bundler.ts 88.8% 0.0% modified
packages/sdk/src/cli/commands/tailordb/migrate/bundler.ts 92.3% 0.0% modified
packages/sdk/src/cli/services/executor/bundler.ts 83.3% 0.0% modified
packages/sdk/src/cli/services/resolver/bundler.ts 91.1% 0.0% modified
packages/sdk/src/cli/services/tailordb/hooks-validate-bundler.ts 82.2% 0.0% modified
packages/sdk/src/cli/services/workflow/bundler.ts 92.0% 0.0% modified

SDK Configure Bundle Size

main (7d7acd2) #736 (7b4db28) +/-
configure-index-size 10.71KB 10.71KB 0KB
dependency-chunks-size 33.72KB 33.72KB 0KB
total-bundle-size 44.42KB 44.42KB 0KB

Runtime Performance

main (7d7acd2) #736 (7b4db28) +/-
Generate Median 2,499ms 2,529ms 30ms
Generate Max 2,514ms 2,687ms 173ms
Apply Build Median 2,526ms 2,592ms 66ms
Apply Build Max 2,535ms 2,645ms 110ms

Type Performance (instantiations)

main (7d7acd2) #736 (7b4db28) +/-
tailordb-basic 42,977 42,977 0
tailordb-optional 3,927 3,927 0
tailordb-relation 4,071 4,071 0
tailordb-validate 2,925 2,925 0
tailordb-hooks 5,790 5,790 0
tailordb-object 11,571 11,571 0
tailordb-enum 2,793 2,793 0
resolver-basic 9,236 9,236 0
resolver-nested 25,623 25,623 0
resolver-array 17,859 17,859 0
executor-schedule 4,244 4,244 0
executor-webhook 883 883 0
executor-record 4,847 4,847 0
executor-resolver 4,270 4,270 0
executor-operation-function 877 877 0
executor-operation-gql 879 879 0
executor-operation-webhook 898 898 0
executor-operation-workflow 2,290 2,290 0

Reported by octocov

@remiposo
remiposo marked this pull request as ready for review March 12, 2026 03:23
@remiposo remiposo self-assigned this Mar 12, 2026
toiroakr
toiroakr approved these changes Mar 12, 2026
View reviewed changes

@toiroakr toiroakr left a comment

Copy link
Copy Markdown
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@remiposo
remiposo merged commit 151f3e6 into main Mar 12, 2026
39 of 44 checks passed
@remiposo
remiposo deleted the fix/replace-deprecated-inlineDynamicImports branch March 12, 2026 05:06
This was referenced Mar 12, 2026
Closed
Merged
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

@devin-ai-integration devin-ai-integration[bot] devin-ai-integration[bot] left review comments
@toiroakr toiroakr toiroakr approved these changes

Assignees

@remiposo remiposo

Labels

None yet

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

2 participants

@remiposo @toiroakr