Repository navigation
Conversation
Codecov Report✅ All modified and coverable lines are covered by tests. Additional details and impacted files@@ Coverage Diff @@
## main #703 +/- ##
==========================================
+ Coverage 92.81% 92.82% +0.01%
==========================================
Files 133 133
Lines 8863 8876 +13
==========================================
+ Hits 8226 8239 +13
Misses 637 637 ☔ View full report in Codecov by Harness. 🚀 New features to boost your workflow:
|
This branch has not been deployed
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Fixes #702.
The one-mode matrix-factor branch of
cp_to_tensorreturns before the existing implicit-weight fallback and mask application. Omitted weights therefore raiseTypeError, and explicit weights with a mask silently produce the unmasked vector.Move the unit-weight fallback before this branch and apply the supplied mask to its result. Four compact regression/control cases use literal expected vectors and exercise both tuple and
CPTensorinputs. They cover a single factor matrix with two component columns; the rank-one vector-factor path from #653 remains separate.Validation on Windows, CPython 3.12.14, NumPy 2.3.5 and SciPy 1.16.3:
PyTorch 2.8.0 was tested on CPU. Existing environments and dependencies were reused without changes. The other backend, Python-version and operating-system matrices, documentation and package builds were not run locally.