Visitar URL original
Make LocalstackContainer.Service extensible by joshiste · Pull Request #3711 · testcontainers/testcontainers-java · GitHub
Skip to content

Make LocalstackContainer.Service extensible - #3711

Closed
joshiste wants to merge 1 commit into
testcontainers:masterfrom
joshiste:feature/localstack-no-service-enum
Closed

joshiste wants to merge 1 commit into
testcontainers:masterfrom
joshiste:feature/localstack-no-service-enum

Conversation

@joshiste

@joshiste joshiste commented Jan 20, 2021 •

Copy link
Copy Markdown

Until now the enum doesn't list all services available in localstack and
since it's an enum the users of this module can't add their own
definitions.
This commit turns the enum into a class with constants to make it
extensible and more future proof if new services get added to localstack.

Until now the enum doesn't list all services available in localstack and
since it's an enum the users of this module can't add their own
definitions.
This commit turns the enum into a class witch constants to make it
extensible and more future proof if new services get added to localstack.
@bsideup

bsideup commented Apr 12, 2021

Copy link
Copy Markdown
Member

Superseded by #3995

@bsideup bsideup closed this Apr 12, 2021
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants