Visitar URL original
Implement #233: add where condition to tabular persister by jakubriedl · Pull Request #234 · tinyplex/tinybase · GitHub
Skip to content

Implement #233: add where condition to tabular persister #234

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Closed
jakubriedl wants to merge 8 commits into from
Closed

Implement #233: add where condition to tabular persister #234

Changes from 1 commit
Commits
Show all changes
8 commits
Select commit Hold shift + click to select a range
b2483f9
add where condition to tabular persister
jakubriedl Apr 25, 2025
6d2585f
WIP: persister specific triggers
jakubriedl Apr 26, 2025
3b14e25
expose when condition
jakubriedl Apr 26, 2025
d5b745a
condition with placeholder
jakubriedl Apr 27, 2025
bd7c731
separate triggers for each operation for correct filtering
jakubriedl Apr 27, 2025
32f7084
fix issue with pglite identifier
jakubriedl Apr 27, 2025
6ed167c
debugging [to be reverted]
jakubriedl Apr 27, 2025
a3556e9
scope partial delete
jakubriedl Apr 28, 2025
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
Prev Previous commit
Next Next commit
fix issue with pglite identifier
  • Loading branch information
@jakubriedl
jakubriedl committed Apr 27, 2025
commit 32f708424b646716b03cca796d65e66ae7465ae5
2 changes: 1 addition & 1 deletion src/persisters/common/database/postgresql.ts
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -51,7 +51,7 @@ export const createCustomPostgreSqlPersister = <
getThing = 'getDb',
): Persister<Persist> => {
const executeCommand = getWrappedCommand(rawExecuteCommand, onSqlCommand);
const persisterId = getUniqueId(5);
const persisterId = getUniqueId(5).replace(/-/g, '_');

const [isJson, , defaultedConfig, managedTableNamesSet] = getConfigStructures(
configOrStoreTableName,
Expand Down