Repository navigation
Conversation
This branch has not been deployed
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Problem
In
BaseFileLock, contended lock acquisitions track anattemptcounter and callself._poll_delay(poll_interval, attempt)to compute the retry delay (supporting exponential backoff, jitter, and subclass custom backoff hooks).However, in
BaseAsyncFileLock._async_poll_until_acquired(src/filelock/asyncio.py), theattemptcounter was omitted and the delay was hardcoded asdelay = poll_interval. As a result:AsyncStrictSoftFileLock) and custom subclasses overriding_poll_delaynever invoked_poll_delayduring contended polling.Solution
attempt = 0prior to the acquisition poll loop inBaseAsyncFileLock._async_poll_until_acquired.attempt += 1on each retry attempt and pass it toself._poll_delay(poll_interval, attempt), mirroringBaseFileLock._poll_until_acquired.test_poll_contention_invokes_poll_delayintests/test_async_filelock.py.docs/changelog/+async-poll-delay.bugfix.rst.Verification
AssertionError: BaseAsyncFileLock failed to call _poll_delay!).test_async_filelock.pysuite (242 tests passing).ruff checkandruff format --checkpass cleanly.