Visitar URL original
feat(webapp): name of the page in tab titles by kathiekiwi · Pull Request #4517 · triggerdotdev/trigger.dev · GitHub
Skip to content

feat(webapp): name of the page in tab titles - #4517

Merged
kathiekiwi merged 10 commits into
mainfrom
feat/page-tab-titles
Aug 6, 2026
Merged

feat(webapp): name of the page in tab titles#4517
kathiekiwi merged 10 commits into
mainfrom
feat/page-tab-titles

Conversation

@kathiekiwi

@kathiekiwi kathiekiwi commented Aug 5, 2026 •
edited
Loading

Copy link
Copy Markdown
Collaborator

Adds a shared pageMeta() helper and 74 route declarations, so a title reads run_abc | Runs | Trigger.dev — the specific thing first, then the page. Org pages also carry the organization: Team | Acme | Trigger.dev. Inside a project no scope is added, because the dashboard switches projects in every tab at once.

Page names are unchanged; what's new is that a page says which one it is at all. Three wording changes on purpose: the queue page now names the queue, the model page names the model, and entity pages carry their section.

@changeset-bot

changeset-bot Bot commented Aug 5, 2026 •
edited
Loading

Copy link
Copy Markdown

⚠️ No Changeset found

Latest commit: 5f2feae

Merging this PR will not cause a version bump for any packages. If these changes should not result in a new version, you're good to go. If these changes should result in a version bump, you need to add a changeset.

This PR includes no changesets

When changesets are added to this PR, you'll see the packages that this PR includes changesets for and the associated semver types

Click here to learn what changesets are, and how to add one.

Click here if you're a maintainer who wants to add a changeset to this PR

@coderabbitai

coderabbitai Bot commented Aug 6, 2026 •
edited
Loading

Copy link
Copy Markdown
Contributor

Review Change Stack

Walkthrough

Added a shared pageMeta utility that composes page, organization, project, environment, and application environment title segments. Updated the root title fallback to use appTitle. Migrated project, organization, account, onboarding, and integration routes to shared metadata declarations. Added dynamic titles for entity routes and page metadata for routes without titles. Added tests for inheritance, scoping, fallbacks, dynamic data, environment labels, and preserved root metadata.

🚥 Pre-merge checks | ✅ 3 | ❌ 2

❌ Failed checks (2 warnings)

Check name Status Explanation Resolution
Docstring Coverage ⚠️ Warning Docstring coverage is 66.67% which is insufficient. The required threshold is 80.00%. Write docstrings for the functions missing them to satisfy the coverage threshold.
Description check ⚠️ Warning The description clearly explains the implementation and intended title format but omits the required issue, checklist, testing, changelog, and screenshots sections. Add the required template sections, complete the checklist, document testing steps, provide a changelog entry, and include screenshots or state that none apply.
✅ Passed checks (3 passed)
Check name Status Explanation
Linked Issues check ✅ Passed Check skipped because no linked issues were found for this pull request.
Out of Scope Changes check ✅ Passed Check skipped because no linked issues were found for this pull request.
Title check ✅ Passed The title clearly summarizes the main change: adding page names to webapp browser tab titles.
✨ Finishing Touches 💡 1
📝 Generate docstrings 💡
  • Create stacked PR
  • Commit on current branch
🧪 Generate unit tests (beta)
  • Create PR with unit tests
  • Commit unit tests in branch feat/page-tab-titles

Thanks for using CodeRabbit! It's free for OSS, and your support helps us grow. If you like it, consider giving us a shout-out.

❤️ Share

Comment @coderabbitai help to get the list of available commands.

@kathiekiwi
kathiekiwi marked this pull request as ready for review August 6, 2026 00:02
@kathiekiwi kathiekiwi changed the title Tab titles that say which page you are on feat(webapp): tab titles that name the page, project and environment Aug 6, 2026
coderabbitai[bot]

This comment was marked as resolved.

Sign in to view

devin-ai-integration[bot]

This comment was marked as resolved.

Sign in to view

@kathiekiwi kathiekiwi changed the title feat(webapp): tab titles that name the page, project and environment feat(webapp): name of the page in tab titles Aug 6, 2026
devin-ai-integration[bot]

This comment was marked as resolved.

Sign in to view

@kathiekiwi
kathiekiwi merged commit 337dda1 into main Aug 6, 2026
39 checks passed
@kathiekiwi
kathiekiwi deleted the feat/page-tab-titles branch August 6, 2026 08:34
@github-actions github-actions Bot mentioned this pull request Aug 6, 2026
Merged
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

@coderabbitai coderabbitai[bot] coderabbitai[bot] left review comments
@devin-ai-integration devin-ai-integration[bot] devin-ai-integration[bot] left review comments
@samejr samejr samejr approved these changes

Assignees

No one assigned

Labels

None yet

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

2 participants

@kathiekiwi @samejr