Visitar URL original
Changed string comparison to use Apache's StringUtils method by KamilZielinski · Pull Request #148 · tronprotocol/java-tron · GitHub
Skip to content

Changed string comparison to use Apache's StringUtils method - #148

Merged
zhaohong merged 1 commit into
tronprotocol:developfrom
KamilZielinski:feature-use-apache-string-utils-for-string-checks
Feb 27, 2018
Merged

zhaohong merged 1 commit into
tronprotocol:developfrom
KamilZielinski:feature-use-apache-string-utils-for-string-checks

Conversation

@KamilZielinski

Copy link
Copy Markdown
Contributor

What does this PR do?

  • Changed checking if string is null or empty to already existing method in Apache StringUtils
  • Changed the name Config -> Configuration
  • Removed duplicated test

Why are these changes required?
Cleanup the code and added tests.

This PR has been tested by:

  • Unit Tests

…ed to full one, added Configuration tests, changed added Lombok's logger
@zhaohong zhaohong self-assigned this Feb 27, 2018
@zhaohong

Copy link
Copy Markdown
Contributor

thanks!

@zhaohong
zhaohong merged commit bc2edc1 into tronprotocol:develop Feb 27, 2018
@ybhgenius

Copy link
Copy Markdown
Contributor

Hello, I am a crew member of TRON, and now we are planning to provide an incentive for your contribution. Please leave me your email address. Thanks.

317787106 added a commit to 317787106/java-tron that referenced this pull request Oct 15, 2026
Port the merged libp2p tronprotocol#148 discovery timeout queue limit and regression tests. Keep java-tron deterministic math and logging conventions.
317787106 added a commit to 317787106/java-tron that referenced this pull request Oct 15, 2026
Port merged libp2p tronprotocol#154 to the in-tree p2p module. Preserve distinct channels through registry, pool, keepalive, and status accounting, with lifecycle regression coverage. Match channels by instance in java-tron PeerManager so its callbacks retain the correct peer when addresses collide. Advance the upstream synchronization marker to f13c67c, which includes tronprotocol#154 and tronprotocol#148.
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants