Visitar URL original
fix(jsonrpc): correct TransactionResult.nonce per JSON-RPC spec by waynercheung · Pull Request #6709 · tronprotocol/java-tron · GitHub
Skip to content

fix(jsonrpc): correct TransactionResult.nonce per JSON-RPC spec - #6709

Merged
lvs0075 merged 1 commit into
tronprotocol:developfrom
waynercheung:fix/jsonrpc-tx-info-quantity-format-6547
May 8, 2026
Merged

fix(jsonrpc): correct TransactionResult.nonce per JSON-RPC spec#6709
lvs0075 merged 1 commit into
tronprotocol:developfrom
waynercheung:fix/jsonrpc-tx-info-quantity-format-6547

Conversation

@waynercheung

@waynercheung waynercheung commented Apr 27, 2026 •
edited
Loading

Copy link
Copy Markdown
Collaborator

What this PR does

Corrects the nonce field in TransactionResult, the response body shared by eth_getTransactionByHash, eth_getTransactionByBlockHashAndIndex, eth_getTransactionByBlockNumberAndIndex, and the full-tx mode of eth_getBlockByHash / eth_getBlockByNumber.

Closes #6547.

Why

Per ethereum/execution-apis:

  • TransactionInfo.nonce is uint (QUANTITY), pattern ^0x(0|[1-9a-f][0-9a-f]*)$ - no leading zeros; zero is 0x0.

java-tron's TransactionResult previously emitted ByteArray.toJsonHex(new byte[8]) -> "0x0000000000000000" (16 hex chars), which violates the pattern.

What changes

Field Path Before After
nonce both TransactionResult constructors 0x0000000000000000 0x0

Why Block.nonce is intentionally NOT changed

Block.nonce is bytes8 per the spec (pattern ^0x[0-9a-f]{16}$), so the existing 0x0000000000000000 is already compliant. Shortening it to 0x0 would break conformance with the bytes8 length requirement.

BlockResult.nonce is therefore left untouched and existing JsonrpcServiceTest assertions on it ("0x0000000000000000") remain valid.

Compatibility

This PR makes a minimal, surgical change: only the nonce literal value is modified. All other fields in TransactionResult retain their existing serialization, preserving byte-for-byte compatibility with current production responses.

The numeric semantics of nonce are unchanged (Long.parseLong of either value yields 0); only the string representation tightens to the spec-compliant form.

Tests

TransactionResultTest is updated to:

  • Assert nonce == "0x0" in both test methods (covering both TransactionResult constructors).
  • Validate nonce against the schema regex ^0x(0|[1-9a-f][0-9a-f]*)$ via a small assertQuantity helper, so any future regression that re-introduces a leading-zero form will fail the test.

Pre-submit checklist

  • Single module (jsonrpc), single issue (The nonce returned by eth_getTransactionByHash is non-compliant #6547), 2 files changed
  • Code style follows Google Java Style
  • No debug code / temporary comments / stray TODOs
  • No unsafe numeric ops introduced
  • No log-level changes
  • No DB schema / consensus / config changes
  • No dependency upgrades
  • Comments explain WHY (the spec rationale), not WHAT

@waynercheung waynercheung mentioned this pull request Apr 27, 2026
Closed
@waynercheung waynercheung changed the title fix(jsonrpc): correct zero-value QUANTITY/null format violations in TransactionResult fix(jsonrpc): correct QUANTITY/null format in TransactionResult Apr 27, 2026
@halibobo1205 halibobo1205 added topic:api rpc/http related issue topic:json-rpc labels Apr 28, 2026
@halibobo1205 halibobo1205 added this to the GreatVoyage-v4.8.2 milestone Apr 28, 2026
bladehan1
bladehan1 reviewed Apr 28, 2026
View reviewed changes
Comment thread framework/src/main/java/org/tron/core/services/jsonrpc/types/TransactionResult.java Resolved
bladehan1
bladehan1 reviewed Apr 28, 2026
View reviewed changes
Comment thread framework/src/test/java/org/tron/core/services/jsonrpc/TransactionResultTest.java Resolved
bladehan1
bladehan1 reviewed Apr 28, 2026
View reviewed changes
Comment thread framework/src/main/java/org/tron/core/services/jsonrpc/types/TransactionResult.java Resolved
@waynercheung
waynercheung requested a review from bladehan1 April 29, 2026 03:24
@waynercheung
fix(jsonrpc): correct TransactionResult.nonce per JSON-RPC spec
ef27b6d 
Per ethereum/execution-apis, TransactionInfo.nonce is `uint` (QUANTITY)
and must match `^0x(0|[1-9a-f][0-9a-f]*)$`. java-tron emitted the field
as `0x0000000000000000` via `ByteArray.toJsonHex(new byte[8])`, which
violates the pattern. Both `TransactionResult` constructors now emit
`"0x0"`.

Block.nonce is intentionally left at `0x0000000000000000` because the
Block schema defines it as `bytes8`, so that value is already compliant
and shortening it would break conformance.

Closes tronprotocol#6547
@waynercheung
waynercheung force-pushed the fix/jsonrpc-tx-info-quantity-format-6547 branch from cc50549 to ef27b6d Compare April 30, 2026 09:39
@waynercheung waynercheung changed the title fix(jsonrpc): correct QUANTITY/null format in TransactionResult fix(jsonrpc): correct TransactionResult.nonce per JSON-RPC spec Apr 30, 2026
@waynercheung

waynercheung commented Apr 30, 2026

Copy link
Copy Markdown
Collaborator Author

After review discussion, the scope of this PR has been narrowed to only the nonce field - the change directly addressing #6547. All other fields previously modified in earlier commits (v / r / s in the unsigned-signature branch, blockHash / blockNumber / transactionIndex / gasPrice in the fallback constructor) have been reverted to their original behavior to maintain strict byte-level compatibility with current production responses.

The branch has been force-pushed to a single minimal commit. Earlier inline comments on the now-removed changes are no longer applicable; please re-review the latest state.

halibobo1205
halibobo1205 approved these changes Apr 30, 2026
View reviewed changes

@halibobo1205 halibobo1205 left a comment

Copy link
Copy Markdown
Collaborator

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

0xbigapple
0xbigapple reviewed Apr 30, 2026
View reviewed changes
Comment thread framework/src/main/java/org/tron/core/services/jsonrpc/types/TransactionResult.java Resolved
yanghang8612
yanghang8612 approved these changes May 6, 2026
View reviewed changes

@yanghang8612 yanghang8612 left a comment

Copy link
Copy Markdown
Collaborator

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

bladehan1
bladehan1 approved these changes May 7, 2026
View reviewed changes

@bladehan1 bladehan1 left a comment

Copy link
Copy Markdown
Collaborator

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@waynercheung
waynercheung requested a review from 0xbigapple May 7, 2026 07:42
0xbigapple
0xbigapple approved these changes May 8, 2026
View reviewed changes

@0xbigapple 0xbigapple left a comment

Copy link
Copy Markdown
Collaborator

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@lvs0075
lvs0075 merged commit 03bd4af into tronprotocol:develop May 8, 2026
17 of 18 checks passed
@github-project-automation github-project-automation Bot moved this to Done in java-tron May 8, 2026
@0xbigapple 0xbigapple mentioned this pull request Jul 17, 2026
Closed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

@yanghang8612 yanghang8612 yanghang8612 approved these changes
@halibobo1205 halibobo1205 halibobo1205 approved these changes
@bladehan1 bladehan1 bladehan1 approved these changes
@0xbigapple 0xbigapple 0xbigapple approved these changes

Assignees

No one assigned

Labels

topic:api rpc/http related issue topic:json-rpc

Projects

java-tron
Status: Done

Milestone

GreatVoyage-v4.8.2

Development

Successfully merging this pull request may close these issues.

The nonce returned by eth_getTransactionByHash is non-compliant

6 participants

@waynercheung @yanghang8612 @halibobo1205 @bladehan1 @0xbigapple @lvs0075