Repository navigation
Add TIP-935: Harden ECDSA Signature Validation (Last Call) - #939
Open
Federico2014 wants to merge 9 commits into
Open
Federico2014 wants to merge 9 commits into
Federico2014 wants to merge 9 commits into
Conversation
hichammchi80-oss
approved these changes
Oct 13, 2026
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
Add TIP-935, Harden ECDSA Signature Validation, from the specification in #935, and list it in README.md in numerical order. The TIP enters Last Call for wider review, retaining its original author and creation date.
The specification preserves the inclusive 65–68-byte signature-length range at RPC/P2P transaction admission, auxiliary queries, and relay HELLO, and in strict transaction and direct witness validation after governance activation. Recovery interprets the first 65 bytes while accepted transaction signatures retain their full original bytes. P2P witness normalization separately retains a copied 65-byte prefix.
At P2P transaction ingress, any signature outside 65–68 bytes rejects the entire batch and disconnects the sender with
BAD_TX, before task submission or request cleanup. Existing disconnect recovery handles outstanding requests. RPC length failures returnSIGERROR.The TIP also covers strict recovery checks, historical compatibility, permission migration, and required conformance coverage. It reflects the ECDSA-only release, auxiliary-query error precedence, Java API migration, and temporary activation-time capacity impact.
Discussion: #935.
Test plan
git diff --checkon the documentation update.This PR adds documentation only. The implementation's regression tests were inspected, not executed for this documentation update; the conformance and integration tests listed in the TIP remain implementation requirements.