Visitar URL original
feat: Upgrade to 3.8.1 with tooltip updates by werdnanoslen · Pull Request #2962 · trussworks/react-uswds · GitHub
Skip to content

feat: Upgrade to 3.8.1 with tooltip updates - #2962

Closed
werdnanoslen wants to merge 3 commits into
mainfrom
an-3.8.1
Closed

feat: Upgrade to 3.8.1 with tooltip updates#2962
werdnanoslen wants to merge 3 commits into
mainfrom
an-3.8.1

Conversation

@werdnanoslen

@werdnanoslen werdnanoslen commented Jun 24, 2024

Copy link
Copy Markdown
Contributor

Summary

This updates us to the latest uswds version, 3.8.1, which had two changes that required PRs here:

How To Test

  1. Run new tests
  2. Open tooltip stories and confirm (1) that you can hover on the tooltip body and (2) dismiss it by keyboard only with the Escape (and no other) key. Previously, we had set it so that any key would dismiss, which was neither helpful in general nor accessible by keyboard navigation.

@werdnanoslen
werdnanoslen requested a review from a team as a code owner June 24, 2024 21:47
@github-actions

github-actions Bot commented Jun 24, 2024

Copy link
Copy Markdown
Contributor
Warnings
⚠️ This PR does not include changes to storybook, even though it affects component code.

Generated by 🚫 dangerJS against 35d84e2

@werdnanoslen werdnanoslen mentioned this pull request Jun 24, 2024
Closed
@werdnanoslen

werdnanoslen commented Jun 24, 2024

Copy link
Copy Markdown
Contributor Author

Merged into #2848

@werdnanoslen
werdnanoslen deleted the an-3.8.1 branch June 24, 2024 21:53
@mdmower-csnw mdmower-csnw mentioned this pull request Sep 20, 2025
Merged
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

No reviews

Assignees

No one assigned

Labels

None yet

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

1 participant

@werdnanoslen