Visitar URL original
Improve workflow compilation performance by cookingwithvlad-del · Pull Request #1106 · tt-a1i/archify · GitHub
Skip to content

Improve workflow compilation performance #1106

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Open
cookingwithvlad-del wants to merge 1 commit into
base: dev
Choose a base branch
from
Open

Improve workflow compilation performance #1106

Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
22 changes: 16 additions & 6 deletions archify/renderers/workflow/workflow-compiler.mjs
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -950,11 +950,16 @@ function createWorkflowLaneGeometry(workflow, layout, legendExtraHeight, minimum
return layout.groupFooterHeights?.[index] ?? 0;
}

const laneTops = [];
let precedingLaneHeight = 0;
for (let index = 0; index < asArray(workflow.lanes).length; index += 1) {
laneTops[index] = layout.laneY + precedingLaneHeight + index * layout.laneGap;
precedingLaneHeight += laneHeight(index);
}

function laneTop(id) {
const index = laneIndex.get(id);
const precedingHeight = asArray(workflow.lanes).slice(0, index)
.reduce((total, _lane, lanePosition) => total + laneHeight(lanePosition), 0);
return layout.laneY + precedingHeight + index * layout.laneGap;
return laneTops[index] ?? Number.NaN;
}

function lastLaneBottom() {
Expand Down Expand Up @@ -1046,16 +1051,21 @@ function workflowNodeTextProblems(node, nodeTextFit) {
// Step indexes: where each edge and node sits on the main path. Lifted out so
// the compiler body keeps only the phases that read them.
function createWorkflowStepIndexes(workflow) {
const mainPathSteps = new Map(asArray(workflow.mainPath).map((id, index) => [id, index]));
const mainPath = asArray(workflow.mainPath);
const mainPathSteps = new Map(mainPath.map((id, index) => [id, index]));
const edgeSteps = new Map(asArray(workflow.edges).map((edge, index) => {
const fromStep = mainPathSteps.get(edge.from);
const toStep = mainPathSteps.get(edge.to);
const mainStep = Number.isInteger(fromStep) && toStep === fromStep + 1 ? fromStep : null;
return [edge, mainStep ?? asArray(workflow.mainPath).length + index];
return [edge, mainStep ?? mainPath.length + index];
}));
const nodeIndexes = new Map();
for (const [index, node] of asArray(workflow.nodes).entries()) {
if (!nodeIndexes.has(node.id)) nodeIndexes.set(node.id, index);
}

function nodeStep(node) {
return mainPathSteps.get(node.id) ?? asArray(workflow.mainPath).length + asArray(workflow.nodes).findIndex((item) => item.id === node.id);
return mainPathSteps.get(node.id) ?? mainPath.length + (nodeIndexes.get(node.id) ?? -1);
}

return { mainPathSteps, edgeSteps, nodeStep };
Expand Down
Loading