perf(dataflow): avoid repeated flow index scans - #1109

No actionable comments were generated in the recent review.

Recent review info

Run configuration

• Source mode: Auto
• Repository: tt-a1i/archify
• Branch: dev
• File: .coderabbit.yaml
• Commit: 10b4dd5
• Layers: Repository YAML
• Review profile: CHILL
• Plan: Advanced
• Run ID: e9432992-620f-494a-b5db-4bc9e8a76e5e

Commits

Reviewing files that changed from the base of the PR and between 10b4dd5 and 34a4d34.

Files selected for processing: 2

• archify/renderers/dataflow/dataflow-compiler.mjs
• test/dataflow-automatic-layout.test.mjs

Included review availability: This review used your included allowance. Your plan provides up to 10 included reviews per hour; 9 remain after this review.

Merge Risk: Minimal · up to 34a4d

No actionable merge-blocking risk was identified in the indexed flow-validation change.

Pre-merge checks: 1 · 1

Failed checks: 1 warning

Check name	Status	Explanation	Resolution
Contribution Scope		The implementation is narrow and the PR explains the problem, preserved diagnostic behavior, failure case, and focused test. However, CONTRIBUTING.md requires a related issue and explicit maintainer a…	Link the related improvement issue or recorded maintainer decision that approves the repeated-scan problem, value, and intended scope. If none exists, record that maintainer decision before final review, then update the PR description with …

Passed checks: 1 passed

Check name	Status	Explanation
Validation Evidence		PASS. Evaluated head 34a4d345 against base 10b4dd5c. The diff changes validateDataflow to use flowList.entries() and preserves the indexed diagnostic path and fix strings. The added public CLI…

Full details: Validation Evidence

Explanation

PASS. Evaluated head 34a4d345 against base 10b4dd5c. The diff changes validateDataflow to use flowList.entries() and preserves the indexed diagnostic path and fix strings. The added public CLI regression checks /flows/2/to, failure status, and fix targets. The author reports the focused suites passed with 181 tests and 0 skipped; this result was not independently rerun. No visual or generated-output evidence is required. Runtime speed is not benchmarked, and the PR discloses that limitation, so no unsupported speedup claim is presented.

Full details: Contribution Scope

Explanation

The implementation is narrow and the PR explains the problem, preserved diagnostic behavior, failure case, and focused test. However, CONTRIBUTING.md requires a related issue and explicit maintainer agreement for performance and test changes before a formal PR (lines 10 and 22–23). The PR states “no separate issue” and provides no linked issue or recorded maintainer decision. This is a scope-readiness gap, not a confirmed runtime defect.

Resolution

Link the related improvement issue or recorded maintainer decision that approves the repeated-scan problem, value, and intended scope. If none exists, record that maintainer decision before final review, then update the PR description with the link.

• Autofix · Keep fixing CodeRabbit findings and required CI, and resolving merge conflicts

Thanks for using CodeRabbit! It's free for OSS, and your support helps us grow. If you like it, consider giving us a shout-out.

_{Comment @coderabbitai help to get the list of available commands.}

Adapted 34a4d345 and its public-CLI regression into our customized 3.2.0 fork: implementation, tests and scoped attribution.

The ordinary JSON case retains /flows/2/to and its offered fix targets. I also reproduced a JavaScript API edge case: placing the same invalid flow object at positions 0 and 2 reported /flows/0/from twice. Indexed iteration now correctly reports /flows/0/from and /flows/2/from; a regression fails before the change and passes afterward.

87 focused tests pass. Sixteen complete before/after results for ordinary inputs, including invalid endpoints, repeated values and empty flows, match. No Dataflow throughput benchmark was performed.

The combined adaptation passed 3,481 general tests (134 conditional skips), 315 Chrome tests (10 skips) and 56 final package checks. Installation readback matches all 215 managed files; Node 22/26 compiler/CLI and previous-customization probes pass. The retained MIT base and the adapted Apache-2.0 portions keep their respective notices.

BlueboxC

Thank you for #1109 and #1106. We have now weighed both against ongoing maintenance cost and would like to retain both narrow changes: #1109 removes an unnecessary lookup without adding state; #1106 keeps its precomputed indexes local to a compile and preserves the existing output contract. Neither should be advertised as an established end-to-end Agent generation speedup.

For both PRs, the remaining contributor action is one explicit personal-review confirmation and AI-use disclosure covering the submitted changes. The assistance information already present can be reused; please confirm only after actually reviewing and understanding the changes. Please also synchronize current dev and rebuild the canonical ZIP, which is currently failing freshness checks, then obtain final-head CI.

No new issue, five-project generation matrix, additional optimization candidates, or broad defensive refactor is requested. Existing focused checks and equivalent-output/stress evidence remain usable at their recorded revisions. We will keep these pending rather than merge before the contributor responsibility and packaging requirements are satisfied. Thank you for keeping the changes small.