Visitar URL original
fix(pep440): skip pre-releases when the pattern is a constraint by loispostula · Pull Request #10546 · updatecli/updatecli · GitHub
Skip to content

fix(pep440): skip pre-releases when the pattern is a constraint #10546

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
olblak merged 1 commit into from
Sep 18, 2026
Merged

fix(pep440): skip pre-releases when the pattern is a constraint #10546

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
9 changes: 9 additions & 0 deletions pkg/plugins/utils/version/pep440.go
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -75,6 +75,15 @@ func (p *Pep440) Search(versions []string) error {
return fmt.Errorf("%s", err)
}

// A pre-release only qualifies once no stable version satisfies the constraint.
for _, v := range p.versions {
if specifiers.Check(v) && !v.IsPreRelease() {
p.FoundVersion.ParsedVersion = v.String()
p.FoundVersion.OriginalVersion = v.Original()
return nil
}
}

for _, v := range p.versions {
if specifiers.Check(v) {
p.FoundVersion.ParsedVersion = v.String()
Expand Down
24 changes: 24 additions & 0 deletions pkg/plugins/utils/version/pep440_test.go
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -130,6 +130,30 @@ var (
ExpectedParsedVersion: "1.0b2",
ExpectedOriginalVersion: "1.0b2",
},
{
// Constraint skips the pre-release in favor of the highest matching stable version.
Pep440: Pep440{
Constraint: ">=15,<16",
},
Versions: []string{"14.0.0", "15.6.1", "15.7.0b1", "16.0.0"},
SortedVersions: []string{"16.0.0", "15.7.0b1", "15.6.1", "14.0.0"},
ExpectedInitErr: nil,
ExpectedSearchErr: nil,
ExpectedParsedVersion: "15.6.1",
ExpectedOriginalVersion: "15.6.1",
},
{
// Constraint falls back to the highest matching pre-release when no stable version matches.
Pep440: Pep440{
Constraint: ">2.0",
},
Versions: []string{"2.0", "2.1.0b3", "2.1.0rc2"},
SortedVersions: []string{"2.1.0rc2", "2.1.0b3", "2.0"},
ExpectedInitErr: nil,
ExpectedSearchErr: nil,
ExpectedParsedVersion: "2.1.0rc2",
ExpectedOriginalVersion: "2.1.0rc2",
},
{
// Empty constraint behaves identically to wildcard: skips pre-releases.
Pep440: Pep440{
Expand Down
Loading