Visitar URL original
deps: update golangci-lint to v2.14.0 by olblak · Pull Request #10838 · updatecli/updatecli · GitHub
Skip to content

deps: update golangci-lint to v2.14.0 - #10838

Merged
olblak merged 2 commits into
updatecli:mainfrom
olblak:ignore/g703
Oct 13, 2026
Merged

deps: update golangci-lint to v2.14.0#10838
olblak merged 2 commits into
updatecli:mainfrom
olblak:ignore/g703

Conversation

@olblak

@olblak olblak commented Oct 13, 2026 •
edited by coderabbitai Bot
Loading

Copy link
Copy Markdown
Member

Update golangci-lint to v2.14.0

Test

To test this pull request, you can run the following commands:

cd <to_package_directory>
go test

Additional Information

Checklist

  • I have updated the documentation via pull request in website repository.
  • I have tested this pull request manually with a custom Updatecli build and it works as expected.

Tradeoff

Potential improvement

Summary by CodeRabbit

  • Chores
    • Updated the automated Go code checks to a newer version.
    • Clarified how environment- and manifest-provided paths are handled in security checks. Existing file checks behave the same.

@olblak
deps: update golangci-lint to v2.14.0
dca46a0 
Signed-off-by: Olblak <me@olblak.com>
@olblak olblak added the dependencies Pull requests that update a dependency file label Oct 13, 2026
@olblak
olblak enabled auto-merge (squash) October 13, 2026 15:49
@coderabbitai

coderabbitai Bot commented Oct 13, 2026 •
edited
Loading

Copy link
Copy Markdown

Review in Change Stack →

Important

Review skipped

Review was skipped as selected files did not have any reviewable changes.

⚙️ Run configuration
  • Configuration used: defaults
  • Review profile: CHILL
  • Plan: Advanced
  • Run ID: 969854ca-f41e-4cee-a0fa-8dc6a75c9409
📥 Commits

Reviewing files that changed from the base of the PR and between dca46a0 and 6747f15.

You can disable this status message by setting the reviews.review_status to false in the CodeRabbit configuration file.

Use the checkbox below for a quick retry:

  • 🔍 Trigger review

No actionable comments were generated in the recent review. 🎉

ℹ️ Recent review info
⚙️ Run configuration
  • Configuration used: defaults
  • Review profile: CHILL
  • Plan: Advanced
  • Run ID: 2f4a9ea5-65dc-4f5c-b421-1d2a73b3c9fc
📥 Commits

Reviewing files that changed from the base of the PR and between 318b834 and dca46a0.

📒 Files selected for processing (3)
  • .github/workflows/go.yaml
  • pkg/plugins/autodiscovery/maven/settings_xml.go
  • pkg/plugins/resources/npm/main.go

Included review availability: This review used your included allowance. Your plan provides up to 4 included reviews per hour; 3 remain after this review.

📝 Walkthrough

The Go workflow updates the golangci-lint action version. The Maven and npm filesystem path checks gain comments about their path sources. The Maven check also adds a G703 suppression. The path-check behavior remains unchanged.

Changes: Path check annotations

Layer / File(s) Summary
Annotate path checks
pkg/plugins/autodiscovery/maven/settings_xml.go, pkg/plugins/resources/npm/main.go		 The Maven and npm checks document their path sources. The Maven check adds a G703 suppression. Both checks retain their existing filesystem behavior.

Go workflow update

Layer / File(s) Summary
Update lint action
.github/workflows/go.yaml		 The workflow updates the golangci-lint action from v2.13.2 to v2.14.0.

Priority: ⬇️ Low

Estimated code review effort: 2 (Simple) | ~10 minutes

Change: Other

Merge Risk: ⚪ Minimal · up to dca46

This change updates the lint version and documents existing path checks without an established user-impacting regression. It is ready to merge subject to normal checks.

Pre-merge checks · Passed 4 · Failed 1

Failed Failed checks (1 warning)

Check name Status Explanation Resolution
Docstring Coverage Warning Docstring coverage is 33.33% which is insufficient. The required threshold is 80.00%. Docstring coverage is scoped to functions touched by this diff. Analyzed 3 functions across 2 files. (1 skipped: 1… Write docstrings for the functions missing them to satisfy the coverage threshold.
Passed Passed checks (4 passed)
Check name Status Explanation
Title check Passed The title clearly and concisely describes the primary change: updating golangci-lint to v2.14.0.
Description check Passed The description includes the change summary, test instructions, checklist, tradeoff, and potential improvement sections. It does not provide a Fix issue reference, and the tradeoff and potential impro…
Linked Issues check Passed Check skipped because no linked issues were found for this pull request.
Out of Scope Changes check Passed Check skipped because no linked issues were found for this pull request.
Full details: Docstring Coverage

Explanation

Docstring coverage is 33.33% which is insufficient. The required threshold is 80.00%. Docstring coverage is scoped to functions touched by this diff. Analyzed 3 functions across 2 files. (1 skipped: 1 unsupported.)

✨ Finishing Touches
🧪 Generate unit tests (beta)
  • Create a new PR
  • Autofix · Keep fixing CodeRabbit findings and required CI, and resolving merge conflicts

Thanks for using CodeRabbit! It's free for OSS, and your support helps us grow. If you like it, consider giving us a shout-out.

❤️ Share

Comment @coderabbitai help to get the list of available commands.

@olblak
olblak merged commit c74ad66 into updatecli:main Oct 13, 2026
7 of 8 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

No reviews

Assignees

No one assigned

Labels

dependencies Pull requests that update a dependency file

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

1 participant

@olblak