Visitar URL original
USWDS - Core: Update comment style for SASS functions · Issue #5217 · uswds/uswds · GitHub
Skip to content

USWDS - Core: Update comment style for SASS functions #5217

Closed as not planned
Closed as not planned

Description

@mejiaj

Is your feature request related to a problem? Please describe.

Use documentation comments instead of CSS style comments to prevent them from being included in compiled CSS.

Example of commented code seen on compile
#5209

Describe the solution you'd like

For example:

- /*
- ========================================
- General-purpose functions
- ----------------------------------------
- */


+ // ==========================================================================
+ // General-purpose functions
+ // ==========================================================================
- /* ln()
- ----------------------------------------
- */

+ //
+ // ln()
+ // ==========================================================================
+
+ /// Computes an exponent.
+ ///
+ /// @param {number} $value
+ ///   The exponent.
+ /// @return {number} `$value` to the power of 10.

Describe alternatives you've considered

No response

Additional context

Following this style will make it easier to integrate sassdoc.
https://sass-lang.com/documentation/syntax/comments#documentation-comments

Related issue:
#2642

Code of Conduct

Activity

  1. added
    Type: Feature RequestCompatibility label; native Enhancement type is authoritative. Retained for templates/search links.
    Affects: DocumentationRelates to documentation. Should this be in uswds-site?
    on Apr 7, 2023
  2. changed the title [-]USWDS - Core: Update comment style for SASS mixins and functions[/-] [+]USWDS - Core: Update comment style for SASS functions[/+] on Apr 7, 2023
  3. moved this to Ready to Schedule in USWDS Core Project Dataon Jun 1, 2023
  4. added
    Role: DevDev expertise is relevant. Project Active Role tracks ownership; this label is not an assignment.
    and removed
    Type: Feature RequestCompatibility label; native Enhancement type is authoritative. Retained for templates/search links.
    on Jun 1, 2023
  5. removed
    Role: DevDev expertise is relevant. Project Active Role tracks ownership; this label is not an assignment.
    on Feb 7, 2025
  6. annepetersen commented on May 1, 2026

    @annepetersen
    Contributor

    May also add to/link to from the USWDS internal engineering guide

  7. added
    Needs: DiscussionAn unresolved decision blocks progress. Name the decision; remove this label when decided.
    on May 1, 2026
  8. ryparker commented on Sep 18, 2026

    @ryparker
    Member

    I'm closing this and #6951 as not planned for now. Converting the comments would remove them from expanded CSS, but it wouldn't change compressed CSS or behavior. We'll improve comments as we work on the affected files instead of doing a separate, broad cleanup.

    If the current comments cause a problem in your expanded CSS or SassDoc workflow, please share an example here. We can revisit a smaller change around that need. The request and patch remain available if we revisit this.

  9. removed
    Needs: DiscussionAn unresolved decision blocks progress. Name the decision; remove this label when decided.
    on Sep 18, 2026
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Metadata

Metadata

Assignees

No one assigned

    Labels

    Affects: BuildRelates to the build processAffects: DocumentationRelates to documentation. Should this be in uswds-site?Context: SassIssue is in Sass

    Projects

      Milestone

      No milestone

      Relationships

      None yet

      Development

      No branches or pull requests

      Issue actions