Visitar URL original
[Button] Use $theme-button-border-radius variable to set button's border-radius by sawyerh · Pull Request #3288 · uswds/uswds · GitHub
Skip to content

[Button] Use $theme-button-border-radius variable to set button's border-radius - #3288

Merged
thisisdano merged 1 commit into
uswds:developfrom
navapbc:sawyerh/theme-big-button-radius
Feb 10, 2020
Merged

thisisdano merged 1 commit into
uswds:developfrom
navapbc:sawyerh/theme-big-button-radius

Conversation

@sawyerh

@sawyerh sawyerh commented Jan 23, 2020 •

Copy link
Copy Markdown
Contributor

Description

$theme-button-border-radius can be customized to change the radius of the .usa-button component, however that currently does not work for .usa-button--big. This fixes what I think was a bug?

Additional information

Before you hit Submit, make sure you’ve done whichever of these applies to you:

  • Follow the 18F Front End Coding Style Guide and Accessibility Guide.
  • Run npm test and make sure the tests for the files you have changed have passed.
  • Run your code through HTML_CodeSniffer and make sure it’s error free.
  • Title your pull request using this format: [Website] - [UI component]: Brief statement describing what this pull request solves.

@sawyerh sawyerh changed the title [Button component] Use $theme-button-border-radius variable to set button's border-radius [Button] Use $theme-button-border-radius variable to set button's border-radius Jan 23, 2020
@sawyerh
sawyerh requested a review from thisisdano January 23, 2020 22:44
@thisisdano

Copy link
Copy Markdown
Contributor

This was a bug, thanks for fixing it!

@thisisdano
thisisdano merged commit f05eced into uswds:develop Feb 10, 2020
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants